This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 106549 - API review: Split of CancellableTask
Summary: API review: Split of CancellableTask
Alias: None
Product: java
Classification: Unclassified
Component: Source (show other bugs)
Version: 6.x
Hardware: All Linux
: P3 blocker (vote)
Assignee: apireviews
Depends on:
Blocks: 106780
  Show dependency tree
Reported: 2007-06-13 17:11 UTC by Tomas Zezula
Modified: 2007-06-15 11:01 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Diff file (8.10 KB, patch)
2007-06-13 17:30 UTC, Tomas Zezula
Details | Diff
Fixed apichanges.xml diff (1.65 KB, patch)
2007-06-13 17:44 UTC, Tomas Zezula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2007-06-13 17:11:21 UTC
The JavaSource.runModificationTask(), runWhenScanFinished() and runUserActionTask() never call the cancel method of the
CancellableTask, so the implementor of such a CancellableTask just writes an empty cancel method. The compatible API
change splits the CancellableTask into Task with run method and CancellableTask which extends the Task by cancel method.
The JavaSource methods mentioned above take Task rather than CancellableTask. The CancellableTask is used only for tasks
registered by factories.
Comment 1 Tomas Zezula 2007-06-13 17:30:54 UTC
Created attachment 43640 [details]
Diff file
Comment 2 Tomas Zezula 2007-06-13 17:44:26 UTC
Created attachment 43641 [details]
Fixed apichanges.xml diff
Comment 3 Jan Lahoda 2007-06-14 15:37:49 UTC
I agree with this change.
Comment 4 Tomas Zezula 2007-06-15 08:59:11 UTC
Checking in apichanges.xml;
/cvs/java/source/apichanges.xml,v  <--  apichanges.xml
new revision: 1.12; previous revision: 1.11
Checking in build.xml;
/cvs/java/source/build.xml,v  <--  build.xml
new revision: 1.7; previous revision: 1.6
Checking in src/org/netbeans/api/java/source/;
/cvs/java/source/src/org/netbeans/api/java/source/,v  <--
new revision: 1.3; previous revision: 1.2
Checking in src/org/netbeans/api/java/source/;
/cvs/java/source/src/org/netbeans/api/java/source/,v  <--
new revision: 1.62; previous revision: 1.61
RCS file: /cvs/java/source/src/org/netbeans/api/java/source/,v
Checking in src/org/netbeans/api/java/source/;
/cvs/java/source/src/org/netbeans/api/java/source/,v  <--
initial revision: 1.1