This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 110136 - API review of ScanDialog.runWhenScanFinished
Summary: API review of ScanDialog.runWhenScanFinished
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Tomas Zezula
Depends on:
Blocks: 96704
  Show dependency tree
Reported: 2007-07-18 13:40 UTC by Tomas Zezula
Modified: 2007-09-26 09:14 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:

Diff file (14.42 KB, patch)
2007-07-18 13:51 UTC, Tomas Zezula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2007-07-18 13:40:14 UTC
The ScanDialog.runWhenScanFinished notifies user about running background scan. When the  background scan is running the
support displays a dialog notifying user about it. When the background scan finishes the dialog is closed and the action
is executed.
Comment 1 Tomas Zezula 2007-07-18 13:51:54 UTC
Created attachment 45311 [details]
Diff file
Comment 2 Vitezslav Stejskal 2007-07-19 08:11:55 UTC
Maybe a naive question, but why is the code showing a dialog rather then using Progress API? Does it mean that calling
this method several times during the classpath scan will popup up several dialogs?
Comment 3 Tomas Zezula 2007-07-19 09:35:21 UTC
The progress is running by default by the initial scan. But user can for example run project and it requires access to
metadata. The dialog is displayed and gives an user a chance to cancel the operation (run project). The dialog is just
one because this method has to be called from event thread.
Comment 4 Andrei Badea 2007-07-19 11:00:21 UTC
Looks fine to me, just minor nitpicks:

1. binary="compatible" deletion="no" deprecation="no" modification="no" semantic="compatible" source="compatible" are
all defaults.

2. the issue number in apichanges.xml is wrong.

3. ScanDialog can be instantiated and subclassed, probably not intentional.
Comment 5 Tomas Zezula 2007-07-19 12:38:44 UTC
Comment 6 Tomas Zezula 2007-07-19 14:21:45 UTC
RCS file: /cvs/java/sourceui/apichanges.xml,v
Checking in apichanges.xml;
/cvs/java/sourceui/apichanges.xml,v  <--  apichanges.xml
initial revision: 1.1
Checking in nbproject/;
/cvs/java/sourceui/nbproject/,v  <--
new revision: 1.3; previous revision: 1.2
Checking in nbproject/project.xml;
/cvs/java/sourceui/nbproject/project.xml,v  <--  project.xml
new revision: 1.4; previous revision: 1.3
Checking in src/org/netbeans/api/java/source/ui/;
/cvs/java/sourceui/src/org/netbeans/api/java/source/ui/,v  <--
new revision: 1.3; previous revision: 1.2
RCS file: /cvs/java/sourceui/src/org/netbeans/api/java/source/ui/,v
Checking in src/org/netbeans/api/java/source/ui/;
/cvs/java/sourceui/src/org/netbeans/api/java/source/ui/,v  <--
initial revision: 1.1
Comment 7 Quality Engineering 2007-09-20 10:46:16 UTC
Reorganization of java component