This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The ScanDialog.runWhenScanFinished notifies user about running background scan. When the background scan is running the support displays a dialog notifying user about it. When the background scan finishes the dialog is closed and the action is executed.
Created attachment 45311 [details] Diff file
Maybe a naive question, but why is the code showing a dialog rather then using Progress API? Does it mean that calling this method several times during the classpath scan will popup up several dialogs?
The progress is running by default by the initial scan. But user can for example run project and it requires access to metadata. The dialog is displayed and gives an user a chance to cancel the operation (run project). The dialog is just one because this method has to be called from event thread.
Looks fine to me, just minor nitpicks: 1. binary="compatible" deletion="no" deprecation="no" modification="no" semantic="compatible" source="compatible" are all defaults. 2. the issue number in apichanges.xml is wrong. 3. ScanDialog can be instantiated and subclassed, probably not intentional.
Fixed
RCS file: /cvs/java/sourceui/apichanges.xml,v done Checking in apichanges.xml; /cvs/java/sourceui/apichanges.xml,v <-- apichanges.xml initial revision: 1.1 done Checking in nbproject/project.properties; /cvs/java/sourceui/nbproject/project.properties,v <-- project.properties new revision: 1.3; previous revision: 1.2 done Checking in nbproject/project.xml; /cvs/java/sourceui/nbproject/project.xml,v <-- project.xml new revision: 1.4; previous revision: 1.3 done Checking in src/org/netbeans/api/java/source/ui/Bundle.properties; /cvs/java/sourceui/src/org/netbeans/api/java/source/ui/Bundle.properties,v <-- Bundle.properties new revision: 1.3; previous revision: 1.2 done RCS file: /cvs/java/sourceui/src/org/netbeans/api/java/source/ui/ScanDialog.java,v done Checking in src/org/netbeans/api/java/source/ui/ScanDialog.java; /cvs/java/sourceui/src/org/netbeans/api/java/source/ui/ScanDialog.java,v <-- ScanDialog.java initial revision: 1.1 done
Reorganization of java component