This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 113051 - Data Source name option is missing
Summary: Data Source name option is missing
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: PC All
: P2 blocker (vote)
Assignee: John Baker
Depends on:
Blocks: 88871 111794
  Show dependency tree
Reported: 2007-08-16 23:57 UTC by John Baker
Modified: 2007-10-10 15:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

screenshot showing the added data source option (34.54 KB, application/octet-stream)
2007-08-20 02:51 UTC, John Baker
diffs of changes to options (11.30 KB, text/plain)
2007-08-20 03:03 UTC, John Baker
Zip of files that contain the changes (7.73 KB, application/octet-stream)
2007-08-20 03:05 UTC, John Baker

Note You need to log in before you can comment on or make changes to this bug.
Description John Baker 2007-08-16 23:57:51 UTC
In M10 there was an option to post a dialog to allow a user to choose a name for a data source
in Tools->Options

The option seems to have been removed.
I'm looking at the Miscellaneous|Visual Web section
Comment 1 Jayashri Visvanathan 2007-08-18 17:19:28 UTC
John, can you check who removed this and why, may be it was intentionally done during the UI clean up. 
Ia m assigning this back to you because Jim has two other bugs.
Comment 2 John Baker 2007-08-20 00:35:03 UTC
There is a section missing from the Miscellaneous | Visual Web section
that was created for M10, but someone removed it.  see attached screenshot
The section provides the capability to post a dialog when dropping a database table onto a visual web page.  This
dialog allows a user to choose their data source name.  This feature was added in M10 as a result of Customer feedback.
This section needs to be restored in the Basic Miscellaneous Visual Web section
Comment 3 John Baker 2007-08-20 00:38:11 UTC
On June 15 there was an integration to allow support of options to show a dialog or not when adding a data source.
However, somehow these options do not appear in the M10 build
Comment 4 John Baker 2007-08-20 00:59:59 UTC
I found a change made on 6/16 to move options from Advanced to Misc
Comment 5 John Baker 2007-08-20 02:01:30 UTC
Turns out the implementation to add the naming option to Tools option was done incorrectly.
A UI section was added to the mf-layer.  As a result Options picked up a new node and added it to Options.

Need to add the naming option feature to options correctly. 
Comment 6 John Baker 2007-08-20 02:26:14 UTC
This blocks 88871.  88871 tracked a feature to allow a user to choose a data source name.
Apparently the implementation to use Tools->Options was incorrect.
As a result the option for this feature no longer appears.

To resolve this, changes are to be made to the 

and JsfDesignerAdvancedOptions

I can attach diffs of changes to make

Comment 7 John Baker 2007-08-20 02:28:17 UTC
All that's needed in the Options UI is one more label with a corresponding checkbox below the last (label-checkbox) pair
in JsfDesignerAdvancedOptionsPanel

Comment 8 John Baker 2007-08-20 02:51:46 UTC
Created attachment 46853 [details]
screenshot showing the added data source option
Comment 9 John Baker 2007-08-20 03:03:10 UTC
Created attachment 46854 [details]
diffs of changes to options
Comment 10 John Baker 2007-08-20 03:05:11 UTC
Created attachment 46855 [details]
Zip of files that contain the changes
Comment 11 John Baker 2007-08-20 03:07:08 UTC
See screenshot showing the option added, diff of source files and a zip file of the sources containing the changes
Comment 12 John Baker 2007-08-20 03:09:43 UTC
Those on the cc list, please review and give feedback
Comment 13 Josef Pavlicek 2007-08-20 12:29:14 UTC
Hi John,
that is OK. You can implement it  - perfect. Please, don't forged to add mnemonics. And please, check the spacing
between components according to UI spec.
Thanks for perfect cooperation.
Comment 14 Pavel Buzek 2007-08-20 18:02:19 UTC
OK with me. Sorry if I accidentally left this option out, feel free to add it.
Comment 15 _ jimdavidson 2007-08-20 20:05:51 UTC
John, thanks for following up on this.   As  you point out, it apparently got dropped in the transition to the new
Options organization.

I discovered it just before I left on vacation, and had exchanged messages with Pavel, Ondrej, and Jan R., but didn't
have time to do a full review.

Your proposal for option name and dialog layout is fine.  For help text, I suggest that we use something like:

"Prompt for Datasource Name: If selected, prompts for the name to use when creating a datasource by dropping a database
table onto the form.  If not selected, the IDE generates the name automatically."

Comment 16 John Baker 2007-08-21 00:19:41 UTC
Fixed.  Still need to add mnemonics and help(tracked by 111794)

Checking in designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/,v  <--
new revision: 1.8; previous revision: 1.7
Checking in designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/,v  <--
new revision: 1.3; previous revision: 1.2
Checking in designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/JsfDesignerAdvancedOptionsPanel.form;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/JsfDesignerAdvancedOptionsPanel.form,v  <--
new revision: 1.2; previous revision: 1.1
Checking in designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/,v  <--
new revision: 1.3; previous revision: 1.2
Comment 17 _ alexpetrov 2007-10-10 15:02:18 UTC
Verified on:
Product Version: NetBeans IDE Dev (Build 200710100000)
Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b02
System: Windows XP version 5.1 running on x86

Tools -> Options -> Miscellaneous (Basic Options) -> Visual Web: Prompt for Data Source Name