This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 120635 - Profiler additional modules should be regular instead of eager ones
Summary: Profiler additional modules should be regular instead of eager ones
Status: RESOLVED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: J Bachorik
URL:
Keywords: ARCH
Depends on:
Blocks:
 
Reported: 2007-10-31 15:21 UTC by J Bachorik
Modified: 2011-11-03 15:35 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J Bachorik 2007-10-31 15:21:47 UTC 
The type of eager doesn't suite profiler additional modules very well as they are more implementation modules than bridges
Comment 1 J Bachorik 2011-10-11 13:59:22 UTC 
has been resolved
Comment 2 Jesse Glick 2011-10-28 22:21:38 UTC 
Resolved by which commit, specifically?

$ fgrep eager *profiler*/nbp*/p*.prop*
maven.profiler/nbproject/project.properties:is.eager=true
profiler.attach.impl/nbproject/project.properties:is.eager=true
profiler.freeform/nbproject/project.properties:is.eager=true
profiler.j2ee.generic/nbproject/project.properties:is.eager=true
profiler.j2ee.jboss/nbproject/project.properties:is.eager=true
profiler.j2ee/nbproject/project.properties:is.eager=true
profiler.j2ee.sunas/nbproject/project.properties:is.eager=true
profiler.j2ee.tomcat/nbproject/project.properties:is.eager=true
profiler.j2ee.weblogic/nbproject/project.properties:is.eager=true
profiler.j2se.impl/nbproject/project.properties:is.eager=true
profiler.j2se/nbproject/project.properties:is.eager=true
profiler.loadgen/nbproject/project.properties:is.eager=true
profiler.nbmodule/nbproject/project.properties:is.eager=true
profiler.snaptracer/nbproject/project.properties:is.eager=true
profiler.stp/nbproject/project.properties:is.eager=true
Comment 3 J Bachorik 2011-10-31 11:35:13 UTC 
Presumably by 839dd57b83d2.
However, not all the eligible modules were turned regular.

Fixed in http://hg.netbeans.org/profiler-main/rev/3d2761bd6d86

The following modules should stay eager.
  maven.profiler
  profiler.attach.impl
  profiler.freeform
  profiler.j2ee
  profiler.j2se
  profiler.loadgen
  profiler.nbmodule
Comment 4 Quality Engineering 2011-11-01 15:14:12 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/3d2761bd6d86
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #120635: Cleaning up profiler modules. Setting eagerness only when appropriate
Comment 5 Quality Engineering 2011-11-03 15:35:53 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/222c26947118
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #120635: Profiler Select Task Panel module needs to be regular and included in the profiler.kit