This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 121412 - [Placeholder] Theme images do not appear on Safari
Summary: [Placeholder] Theme images do not appear on Safari
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All Windows Vista
: P1 blocker (vote)
Assignee: rjspellman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-07 19:28 UTC by Lark Fitzgerald
Modified: 2007-11-08 16:03 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lark Fitzgerald 2007-11-07 19:28:58 UTC
NB6 needs to pick up this fix.

----
https://woodstock.dev.java.net/issues/show_bug.cgi?id=904

It could just be my cache, but while performance testing, I noted that images
are not displayed as expected. I tested Safari 2.0.4 on Mac and 3.0.3 on
Windows. Seems the latest nightly testapp on Sprang.east also has the same issue. 

When I excluded Safari from the combined image map, I could see themed images as
expected. For example, the table pagination icons and other controls finally
appeared on the page. Below is the change I made to the widget/common.js file.

    getImageProps: function(key, props) {
    ...
        if (mapKey != null && !webui.@THEME@.browser.isIe6() 
                && !webui.@THEME@.browser.isSafari()) { <<<< Excluded Safari------- Additional comments from 
animeshkumarsahay Mon Nov 5 11:20:15 +0000 2007 -------

High contrast mode detection works for ie and firefox, safari has issues with
the implementation. A check needs to be added for safari. ------- Additional comments from rjspellman Wed Nov 7 
16:14:39 +0000 2007 -------

This issue was fixed by Dan yesterday, 11/6/2007.
Comment 1 _ krystyna 2007-11-07 20:50:59 UTC
I am not sure if this is the same issue. Here is an old bugster bug closed as a will not fix due
to bug against Safari. Also see, http://bt2ws.central.sun.com/CrPrint?id=6248428
Comment 2 Jayashri Visvanathan 2007-11-07 21:16:32 UTC
Ashvini is working on integrating woodstock binaries that includes the fix. ETA is COB today.
Comment 3 rjspellman 2007-11-07 21:23:00 UTC
Reassigning ownership to me, rjspellman.
Comment 4 Petr Blaha 2007-11-08 10:58:48 UTC
According the commit, the issue is fixed:

User: am111535
Date: 2007/11/07 13:16:25

Modified:
   visualweb/woodstock/components/external/woodstock-components-4.1.zip
   visualweb/woodstock/defaulttheme/external/woodstock-defaulttheme-4.1.zip

Log:
 Integrated WS Build15 component and defaulttheme zips

Lark, can you please verify this? Thanks Then the fix must be merged in release60 branch.
Comment 5 rbalada 2007-11-08 11:29:20 UTC
AFAICT, fix for this issue also involves following integration

User: am111535
Date: 2007/11/07 14:49:05

Modified:
   translatedfiles/src/visualweb/woodstock/components/release/modules/ext/locale/webui-jsf-dt_ja.jar
   translatedfiles/src/visualweb/woodstock/components/release/modules/ext/locale/webui-jsf-dt_pt_BR.jar
   translatedfiles/src/visualweb/woodstock/components/release/modules/ext/locale/webui-jsf-dt_zh_CN.jar

Log:
 - integrate Woodstock Build 15 webui-jsf-dt localized jars
Comment 6 rbalada 2007-11-08 11:38:10 UTC
Marking as fixed to allow further processing according to High Resistance rules. Next Production build is supposed to
pick up the changes. I anticipate to have this build publicly available at around 9pm UTC on November 8th.
Comment 7 rbalada 2007-11-08 11:43:00 UTC
oops. Correction to the information about publicly available production build. Actual NB 6 production build takes just
the release60 branch, not trunk which should be taken for this test case. For testing purposes, please use any recent
build from http://deadlock.netbeans.org/hudson/job/trunk/ . This build is enough for verification test, then we can
integrate to release60 branch.
Comment 8 Lark Fitzgerald 2007-11-08 15:41:48 UTC
This fix was verified yesterday by taking the updated .jar files and replacing them in the 60 build.  Trunk for 
visualweb is broken right now with lexer issues.
Comment 9 Lark Fitzgerald 2007-11-08 16:03:30 UTC
I take it back, the lexer issues were fixed.  The issue I had was vnc related.  I have re-verified this using trunk 
zip, ide stamp: 20071108133813.