This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 127886 - Missing specific code folds actions
Summary: Missing specific code folds actions
Alias: None
Product: editor
Classification: Unclassified
Component: Code folding (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Svata Dedic
Keywords: API
: 126030 142711 (view as bug list)
Depends on:
Reported: 2008-02-20 14:55 UTC by Marek Fukala
Modified: 2012-12-11 15:34 UTC (History)
1 user (show)

See Also:
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2008-02-20 14:55:46 UTC
The implementation of the foldings has changed completely. We no longer use Schlieman engine. Instead of that the HTML,
CSS and JavaScript folds are provided by GSF and the JSP folds by separated JspFoldManager. 

Currently there are no language specific actions (collapse HTML/JSP comments etc.) in the Code Folds menu for none of
these languages.
Comment 1 Marek Fukala 2008-02-20 14:57:40 UTC
*** Issue 126030 has been marked as a duplicate of this issue. ***
Comment 2 Marek Fukala 2008-03-05 19:22:42 UTC
At least we should have expand/collapse comments which is more or less generic for all languages. 

Since the html, css and javascript folding is handled by the GSF infrastructure and the only info currently possible to
pass into the infrastructure from the language specific providers is the fold range, I cannot implement it on my side,
so reassing to GSF. 

Some extension of the framework is welcomed here.
Comment 3 Marek Fukala 2008-04-30 15:25:53 UTC
Basically we need to be able to specify fold type and fold display name like the original editor/folds api allows.
Comment 4 Jayashri Visvanathan 2008-11-25 23:48:03 UTC
Reassigning to the right component, ruby,gsf
Comment 5 David Strupl 2009-01-14 14:36:28 UTC
Moving from ruby/GSF to editor/CSL. Step one: assign to myself ;-)
Comment 6 David Strupl 2009-01-14 14:45:28 UTC
Step 2: trying to make the owner not myself but the owner of the subcomponent.
Comment 7 Miloslav Metelka 2009-03-23 15:38:27 UTC
I guess this will need some designing first since there are:
1) Code folding actions in context-menu->Code Folds
2) Code folding actions in shortcuts in options
3) Possible initial folding checkboxes in Options->Editor->General

Marku, would it suffice to just allow to extend FoldType to allow "importance" (that would imply in which order the expand/collapse actions would appear in 
the "Code Folds" menu) and have FoldType.displayName() to have localized fold type name for the Code Folds menu and Options->Editor->General?
IMHO we could possibly restrict that the extra actions would not have key shortcut assignable (would be just dynamically generated).
Comment 8 David Strupl 2009-06-08 14:05:38 UTC
Marek, these are yours now ...
Comment 9 David Strupl 2010-09-28 14:11:20 UTC
I am changing this to Code Folding category from CSL. I would like to avoid putting anything new into CSL and enhance the editor APIs instead (where it makes sense).
Comment 10 Svata Dedic 2012-12-11 11:06:09 UTC
Marku, there are request, which lead to a per-language folding settings, which I think implies ability to define fold types. See issues #222981, #157709. Fold type name should be covered by those.

There are general expand/collapse actions, and recursive expand action will probably become available in 7.4, which work on all folds, regardless of language.

So the only feature not covered elsewhere is to allow SPI to specify fold's display name, such as HTML tag name - is it ?
Comment 11 Marek Fukala 2012-12-11 11:41:35 UTC
> So the only feature not covered elsewhere is to allow SPI to specify fold's
> display name, such as HTML tag name - is it ?
This is what is needed the most.
Comment 12 Svata Dedic 2012-12-11 11:51:24 UTC
OK, I've found RFE specifically for the missing item - see issue #142711. Thanks for explanation. Since everything in this issue is covered elsewhere, closing as WONTFIX
Comment 13 Svata Dedic 2012-12-11 15:34:16 UTC
*** Bug 142711 has been marked as a duplicate of this bug. ***