This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 136298 - Editor gutter color is hardcoded
Summary: Editor gutter color is hardcoded
Status: RESOLVED WONTFIX
Alias: None
Product: editor
Classification: Unclassified
Component: Painting & Printing (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: David Strupl
URL:
Keywords: L&F, UI
Depends on:
Blocks: 131305
  Show dependency tree
 
Reported: 2008-06-02 17:49 UTC by Ondrej Langr
Modified: 2012-10-28 22:00 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Langr 2008-06-02 17:49:15 UTC
Editor gutter color is hardcoded and does not reflect active L&F. Highly visible in the UI.
Comment 1 Vitezslav Stejskal 2008-06-07 10:59:08 UTC
Ondro, gutter colors are taken from Tools-Options -> Fonts & Colors -> Highlighting -> 'Line Number'. So, you are right
that they don't reflect L&F, but they are customizable by a user the same way as other editor colors. Maybe, we should
enhance our color pickers to allow choosing something like 'L&F default'. What exactly is the problem here?
Comment 2 Ondrej Langr 2008-06-09 13:00:37 UTC
Thanks for explanation, Vita. The problem is that current gutter background color (set by
http://ui.netbeans.org/docs/ui/editor/gutter/glyphgutter-foldingbar.html) has been chosen for winXP look and feel, but
does look pretty bad on nimbus L&F. 

The solution would be to find a color suitable for all L&F (may not even be possible) or use L&F specific color. The
solution with L&F specific in the chooser is fine with me (should be default setting). I will talk with VDs and provide
color code for nimbus theme. 
Comment 3 Ondrej Langr 2008-06-16 14:36:13 UTC
Actually, it seems that the current color is not ideal even for winXP look & feel. The only L&F it goes well with is the
MacOSX, where the color is virtually identical to that of standard color of swing panels. 

Is anyone aware of a historic reason why the gutter has different color from standard system specified color of other
components?
Comment 4 Vitezslav Stejskal 2008-06-17 13:36:49 UTC
> Is anyone aware of a historic reason why the gutter has different color from standard system specified color
> of other components?

Probably not, and I don't think they matter that much. We just have to decide on how to fix it. Ideally, I would prefer
using a color derived from swing (ie. no Netbeans hardcoded colors for different L&Fs).
Comment 5 Ondrej Langr 2008-06-17 13:46:59 UTC
Vita, I agree that what you suggest is the best solution. Let's use standard swing color, but make it customizable (for
use with themes with black or dark background). 
Comment 6 Ondrej Langr 2008-06-17 13:48:49 UTC
Removing the UNCOMPLETE keyword as I believe all information necessary for implementation should be present. If there is
anything needed from HIE, let me know. 
Comment 7 Ondrej Langr 2008-08-15 10:58:35 UTC
After having discussed this with anebuzelsky and dsimonek, I'm summarizing that:
--------------------------------------------------------------------------------

1) the desired default color should be the one used e.g. for background of status line

2) It should remain customizable in Tools-Options -> Fonts & Colors -> Highlighting -> 'Line Number'. This can be done
by either introducing a new value in the combo ("Default" or "Look and Feel default") or by changing the parent element
for the "Inherited" value to something which has the proper color. (I personally think the later approach is the better,
unless there is a particular reason for this inheritance I'm not aware of. What element does the gutter inherit from
right now?)
Comment 8 David Strupl 2012-10-25 13:39:12 UTC
Bug prior to 7.0, not touched for the last 2 years --> P4.
Comment 9 Miloslav Metelka 2012-10-28 22:00:58 UTC
The current customizability as "Line Number" seems straightforward enough for me so I would leave it as it is unless we have a clear solution that would be more intuitive than the current state.

Btw editor (if not undocked) now uses global status line (asked in comment 7).