This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 160493 - Memory leak from AnnotationBar
Summary: Memory leak from AnnotationBar
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: PERFORMANCE, REGRESSION
Depends on:
Blocks:
 
Reported: 2009-03-17 18:58 UTC by Vladimir Voskresensky
Modified: 2009-03-18 22:38 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2009-03-17 18:58:30 UTC 
There is a memory leak from AnnotationBar in mercurial && subversion
http://hg.netbeans.org/main/rev/d455e0e13621
http://hg.netbeans.org/main/rev/c3e39570e65d

Leaked object is Lookup.Result listener hpResult
Please, change it to weak listener

Due to this leak our automatic tests are failing by OOME
Comment 1 Vladimir Voskresensky 2009-03-17 22:19:15 UTC 
Please, do not change priority without justification.
According to http://wiki.netbeans.org/BugPriorityGuidelines this is P1:
- Huge memory leak and OOME with 1Gb of leaked object (each opened file cause leaked object)
- Regression in performance (QA tests for MySQL projects are not finished after 6 hours on 1.7Gb Xmx)
- Blocks another developer's progress, no workaround exists (QA team failed to provide numbers since Saturday)

We need the fix asap, please :-)
Comment 2 soldatov 2009-03-17 22:34:53 UTC 
Has NetBeans command line option in order to switch off mercurial && subversion?
Comment 3 Ondrej Vrabec 2009-03-17 23:31:23 UTC 
fix
hmm, sorry about that, this should fix that

changeset   : 120765:e525616b2568
author      : Ondrej Vrabec <ovrabec@netbeans.org>
date        : Tue Mar 17 23:28:48 CET 2009
summary     : #160493 - Memory leak from AnnotationBar

changeset   : 120763:e517c4e8dcbb
author      : Ondrej Vrabec <ovrabec@netbeans.org>
date        : Tue Mar 17 23:16:05 CET 2009
summary     : #160493 - Memory leak from AnnotationBar
Comment 4 Vladimir Voskresensky 2009-03-17 23:52:51 UTC 
thank you so much!
what is a repository where you pushed the fix?
Comment 5 Ondrej Vrabec 2009-03-17 23:55:37 UTC 
repository - hg.netbeans.org/cdev
Comment 6 Vladimir Voskresensky 2009-03-18 00:01:00 UTC 
thanks
Comment 7 Tomas Stupka 2009-03-18 00:01:43 UTC 
> Please, do not change priority without justification.
> According to http://wiki.netbeans.org/BugPriorityGuidelines this is P1:
> - Huge memory leak and OOME with 1Gb of leaked object (each opened file cause leaked object)
> - Regression in performance (QA tests for MySQL projects are not finished after 6 hours on 1.7Gb Xmx)
> - Blocks another developer's progress, no workaround exists (QA team failed to provide numbers since Saturday)
thanks for the explanation. it wasn't that obvious from the original post:)
Comment 8 Quality Engineering 2009-03-18 22:38:21 UTC 
Integrated into 'main-golden', will be available in build *200903181604* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/e517c4e8dcbb
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #160493 - Memory leak from AnnotationBar