This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 179307 - the javahelp ant task breaks maven usage
Summary: the javahelp ant task breaks maven usage
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Help System (show other bugs)
Version: 6.x
Hardware: All All
: P2 normal (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks: 155111
  Show dependency tree
 
Reported: 2010-01-08 05:56 UTC by Milos Kleint
Modified: 2010-03-12 04:26 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Removes hacks to modify JH search indexer (25.83 KB, patch)
2010-01-11 18:25 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2010-01-08 05:56:42 UTC
since some time (not in 6.0, but present in 6.7 ant tasks) we ship our own classes in package com.sun.java.help.search as part of the tasks.jar. That seems to work fine for ant harness, but unfortunately breaks for maven usage. Took me a while to figure but it's caused by the fact that the only publicly available javahelp binary in the central repository is signed (which the binary we ship isn't) and as such the classloading fails as classes in the same package need to have the same signatures. P2 as it cripples the usage of javahelp in netbeans maven based modules.

Possible solutions include
1. push a non-signed version of javahelp to central repository
2. getting rid of whatever classes we have in that package.
Comment 1 Jesse Glick 2010-01-11 10:04:24 UTC
Prefer #2. Fixes to JavaHelp should be made upstream, not as patched in NB sources.
Comment 2 Jaroslav Tulach 2010-01-11 10:36:02 UTC
If you prepare patch, I have commit rights to javahelp.
Comment 3 Jesse Glick 2010-01-11 18:25:54 UTC
Created attachment 93201 [details]
Removes hacks to modify JH search indexer

May be applied after https://javahelp.dev.java.net/nonav/issues/show_bug.cgi?id=27 is merged into JH and resulting 2.0_06 released and incorporated into NB.
Comment 4 Jesse Glick 2010-02-01 12:07:17 UTC
Still waiting for assistance releasing a new version of JavaHelp (need help with the TCK). If that cannot be done by 6.9, will consider reverting bug #155111 as this issue is more serious.
Comment 5 Alexei Mokeev 2010-02-09 22:18:36 UTC
Yep, maven usage could be more serious than META keywords. Yet reverting back feature that was in for couple releases is dangerous: hard to estimate it's real usage.

How about option 1:
- push a non-signed version of javahelp to central repository

Is there a reason against it ?
Comment 6 Jesse Glick 2010-03-10 16:21:20 UTC
core-main #82c5416e45ae removes those classes from tasks.jar. There is still one class from JH left in org-netbeans-modules-javahelp.jar for compatibility with old help sets; let me know if that would cause problems too.
Comment 7 Quality Engineering 2010-03-12 04:26:24 UTC
Integrated into 'main-golden', will be available in build *201003120200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/82c5416e45ae
User: Jesse Glick <jglick@netbeans.org>
Log: #179307: revert #155111 impl to avoid problems with Maven.