This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 189472 - Allow annotating an icon of an arbitrary project type
Summary: Allow annotating an icon of an arbitrary project type
Status: RESOLVED WORKSFORME
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Projects UI (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Stupka
URL:
Keywords: API, PERFORMANCE
Depends on: 171516
Blocks: 202592
  Show dependency tree
 
Reported: 2010-08-13 07:55 UTC by Tomas Mysik
Modified: 2016-07-10 19:42 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
proposed fix (10.76 KB, patch)
2010-08-13 07:55 UTC, Tomas Mysik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2010-08-13 07:55:53 UTC
Created attachment 101361 [details]
proposed fix

This enhancement is related to issue #171516.

Maybe it could be sometimes useful to provide icon annotator for only a specific project type (at least for performance reasons). I'm attaching patch that might work.

Feel free to review the patch, change it or simply close this issue if you think that it's useless.

Thanks Jesse.
Comment 1 Jesse Glick 2010-08-13 12:10:21 UTC
[JG01] I guess these impls would be attached using @ProjectServiceProvider. Did you have a particular use case in mind? I cannot think of any. Project badges are generally either agnostic about project type, as for VCS or parser error marks; or part of a more complex warning UI managed by the project type and possibly already extensible via @PSP, as for o.n.m.maven.api.problem.ProblemReporter.


[JG02] Use of the volatile modifier scares me, especially when applied to reference-typed fields. If some sort of thread safety is needed, monitors are usually called for to protect the internal state of the object.


[JG03] Missing additions to ProjectUtilsTest.testAnnotateIcon.


[JG04] Missing spec version change, apichanges.xml entry, Javadoc in PIA.
Comment 2 Jaroslav Tulach 2010-08-13 14:14:47 UTC
Community contributions are always welcomed! Go on Tomáši!
Comment 3 Jesse Glick 2010-08-13 14:38:50 UTC
No current use cases; filed here in case it is useful in the future.
Comment 4 Jesse Glick 2011-10-23 18:13:26 UTC
Regarding JG01, would provide a better solution for bug #202592.
Comment 5 Tomas Zezula 2011-10-26 12:51:54 UTC
The patch will not change any behavior of the issue #202592 but it improve performance (the JFXPIA will be loaded only for J2SEProjects). I will clean up the patch and integrate it in the NB 7.2.
Comment 6 Jesse Glick 2012-03-15 02:43:23 UTC
Sorry, did not get to this in time to file a review prior to 7.2 feature freeze. If this is, or is blocking, a DEFECT then let me know.
Comment 7 Tomas Zezula 2012-03-15 08:19:36 UTC
It's not a blocker for NB 7.2.
Comment 8 markiewb 2013-05-10 17:19:05 UTC
Reset invalid target milestone from 7.3 to TBD
Comment 9 Martin Balin 2016-07-07 08:39:07 UTC
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss