This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199253 - API review: Added possibility to set a display name on Library SPI
Summary: API review: Added possibility to set a display name on Library SPI
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: API, API_REVIEW_FAST
Depends on: 199611
Blocks: 46863 182388
  Show dependency tree
 
Reported: 2011-06-08 08:17 UTC by Tomas Zezula
Modified: 2011-06-23 08:04 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Proposed patch (97.55 KB, patch)
2011-06-08 08:21 UTC, Tomas Zezula
Details | Diff
Proposed patch (97.55 KB, patch)
2011-06-08 08:24 UTC, Tomas Zezula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2011-06-08 08:17:40 UTC
Added displayName property into the Library's SPI allowing an implementor to provide the a display name of the Library which differs from the system (identifying) name.


The NamedLibraryImplementation extending the LibraryImplementation was added into the SPI.

The new Library schema for global libraries was added, for project libraries a property libs.${lib_name}.displayName is used.

New methods createLibrary were added into the LibraryManager.
Comment 1 Tomas Zezula 2011-06-08 08:21:48 UTC
Created attachment 108793 [details]
Proposed patch
Comment 2 Tomas Zezula 2011-06-08 08:24:12 UTC
Created attachment 108794 [details]
Proposed patch
Comment 3 Tomas Zezula 2011-06-08 08:25:58 UTC
I will also do the rewrite for server libraries.
Comment 4 Tomas Zezula 2011-06-08 14:34:22 UTC
The server libraries does not need any change as they are using LibrariesSupport.createLibraryImplementation
Comment 5 Tomas Zezula 2011-06-15 14:13:16 UTC
I will integrate it tomorrow.
Comment 6 Tomas Zezula 2011-06-16 09:14:16 UTC
Fixed jet-main ac7d98ff7208
Comment 7 Jesse Glick 2011-06-20 19:08:31 UTC
[JG01, sorry it is late] The 'version' attribute on <library> is pointless since this is already implied by the namespace you use.
Comment 8 Tomas Zezula 2011-06-21 16:49:34 UTC
Right, the version attribute is useless as the schema implies the version.
I wanted to have the new library definition the same as the previous one. But the version is really useless. I don't see it as a big problem. Removing it may cause problems in reading libraries in dev builds (incompatible change) but probably not many users are using it yet, so it can be probably done. But I would prefer not to do it.