This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199740 - MutiFileFS over BinaryFS is slow
Summary: MutiFileFS over BinaryFS is slow
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 7.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2011-06-27 15:33 UTC by Petr Hrebejk
Modified: 2012-11-05 13:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Profiler snapshot (54.81 KB, application/octet-stream)
2011-06-27 15:37 UTC, Petr Hrebejk
Details
Test to compare MFS and BinaryFS. Bunch of speed ups. (30.24 KB, patch)
2011-06-30 07:07 UTC, Jaroslav Tulach
Details | Diff
Eliminates most of StringBuilder.append and StringTokenizer operations (64.26 KB, patch)
2011-08-05 07:37 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hrebejk 2011-06-27 15:33:26 UTC
Wrapping BinaryFS with a MultiFS is slow. Taking first layer (getDelegates[0]) instead of getRoot on MultiFS makes things several times faster.
Comment 1 Petr Hrebejk 2011-06-27 15:37:29 UTC
Created attachment 109134 [details]
Profiler snapshot

See the number of string operations and contructName calls.
Comment 2 Jaroslav Tulach 2011-06-30 07:07:11 UTC
Created attachment 109160 [details]
Test to compare MFS and BinaryFS. Bunch of speed ups.

This patch is however horribly incompatible with previous behavior of MFS, so it can serve only as an indicator of places where the slowdown happens.
Comment 3 Jaroslav Tulach 2011-08-05 07:37:40 UTC
Created attachment 109808 [details]
Eliminates most of StringBuilder.append and StringTokenizer operations
Comment 4 Jaroslav Tulach 2011-08-05 07:38:58 UTC
I will need to add new factory method, thus asking for review, even the patch is not yet finished. Currently adds 

public static FileSystem create(List<FileSystem> arr);

into MultiFileSystem.
Comment 5 Jaroslav Tulach 2011-10-12 06:33:17 UTC
Startup of 7.1 is faster than 7.0, so lets leave this issue for next release.
Comment 6 Jaroslav Tulach 2012-11-05 13:41:16 UTC
Yes, it is slower. Does not seem to matter that much right now.