This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199951 - versioning.unversionedFolders switch excludes whole disk from versioning
Summary: versioning.unversionedFolders switch excludes whole disk from versioning
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.0
Hardware: All All
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on: 199986
Blocks:
  Show dependency tree
 
Reported: 2011-07-07 15:34 UTC by Ondrej Vrabec
Modified: 2011-07-20 13:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
unit tests (5.19 KB, patch)
2011-07-07 15:35 UTC, Ondrej Vrabec
Details | Diff
fix proposal (1.22 KB, patch)
2011-07-07 15:36 UTC, Ondrej Vrabec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Vrabec 2011-07-07 15:34:49 UTC
If we set versioning.unversionedFolders=NB_USERDIR property, the logic in VersioningManager correctly marks NB_USERDIR as non-versioned (with no VCS owner). But unfortunately it seems that all its parents are marked as unversioned as well. See the attached patch with junit tests demonstrating the fact and a fix proposal.
The fix is trivial and does what we want, but probably worsens performance. I think the best way would be to share unversionedFolders logic among versioning module and all vc systems - in other words making it a part of the API. That way a file/folder could be tested for being an excluded one and the whole logic in VersioningManager could be skipped for unversioned/excluded files, leaving the rest of the code as it is now.
Comment 1 Ondrej Vrabec 2011-07-07 15:35:55 UTC
Created attachment 109295 [details]
unit tests
Comment 2 Ondrej Vrabec 2011-07-07 15:36:47 UTC
Created attachment 109296 [details]
fix proposal
Comment 3 Ondrej Vrabec 2011-07-19 07:45:00 UTC
fix: http://hg.netbeans.org/core-main/rev/95af576cfd18
Comment 4 Quality Engineering 2011-07-20 13:56:48 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/95af576cfd18
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #199951 - versioning.unversionedFolders switch excludes whole disk from versioning