This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 20169 - Attributes copying is broken: affects template copying
Summary: Attributes copying is broken: affects template copying
Alias: None
Product: platform
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Martin Entlicher
Depends on: 120724
Blocks: 25675
  Show dependency tree
Reported: 2002-02-05 15:45 UTC by Jaroslav Tulach
Modified: 2010-10-08 03:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Sample project (9.15 KB, application/zip)
2010-04-02 16:43 UTC, Jesse Glick

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2002-02-05 15:45:05 UTC
The FileUtil.copyAttribute uses simple and straight forward approach to copy
attributes of one file object to another. It asks for the value of the attribute
(the attribute is deserialized) and then saves it to the new object (the
attribute is serialized). 

This causes problems if the classes of the attributes are not available and also
deletes ignores attributes of .nbattrs & xmlfs (newvalue and methodvalue).

As part of work on issue 20168 I have improved the behaviour to just copy the
attributes as XML file. See

Please implement the behaviour into main trunk.
Comment 1 rmatous 2002-03-06 14:36:32 UTC
There is no API. To implement it means in other words to hack
it.Moreover there are complications with decorated attribute names
that are compound from full path and attribute name for
MultiFileObject that doesn`t have on writable layer appropriate

Moreover I think that original need for this enhancement is much
weeker because cache is relaized completely without XMLFileSystem.

I tried to implement it but code was gradually uglier and probably
error prone. So changed to RFE, priority 5, MileStone 4.0.
Comment 2 David Konecny 2002-07-16 13:46:51 UTC
Increasing priority of this enhancement to P2 (it is tempting to 
change it to defect). It is serious problem for new projects where XML 
filesystems are often merged. Please fix if you can ASAP. Thanx!
Comment 3 rmatous 2002-07-16 14:26:57 UTC
I hope that you have read my previous contribution. You must be aware
that there is no definition about attributes at all. Attributes means
value - some Object, that`s all. There is specific impl. for
XMLFileSystem defined in dtd, but it is valid only for XMLFileSystem.
This RFE is a little misleading at all. This RFE is basically RFH
(request for hack), but I`m ready to do it. So,  FileObjects that are
implemented in package filesystems can accept copiing of definition as
impl. detail. But I think that changing this RFH to DEFECT would be
Comment 4 Antonin Nebuzelsky 2008-04-15 17:00:22 UTC
Reassigning to new module owner jskrivanek.
Comment 5 Jesse Glick 2008-07-24 18:46:03 UTC
This is really a DEFECT which makes the impl of copying in favorites.templates.TemplatesPanel not be able to work
reliably. An attempt was made to fix this in #7893ff771dee, mistakenly attributed to issue #140308 (I don't know what
the real issue number was but it was open and commented on recently), but that attempt will not work - it handles
newvalue but not methodvalue.

The only thing I can think of that could work is for XMLMapAttr to keep a (weak) cache of Object's it has created using
newvalue and methodvalue, so that if you try to write them back to disk in some other attribute they will be stored
correctly. But even that would probably not work, since the original reading will likely be done by BinaryFS whereas
XMLMapAttr would do the writing - i.e. the cache would need to be shared between openide.filesystems and core.startup.
Comment 6 Jaroslav Tulach 2010-04-01 21:09:04 UTC
Long time open enhancements without patches don't deserve to be left open.
Comment 7 Jesse Glick 2010-04-02 16:41:37 UTC
Copying templates really is broken. Examples:

Action (apisupport) -> display name stored as serialvalue

Entity Classes from Database -> <attr name="instantiatingIterator" newvalue="null"/>

Java Beans Component: original <attr name="instantiatingIterator" methodvalue=""/> -> copy <attr name="instantiatingIterator" newvalue=""/>
Comment 8 Jesse Glick 2010-04-02 16:43:57 UTC
Created attachment 96613 [details]
Sample project

Run module project. Make a j2seproject. File > New > Other > Special File. Should show current time - OK.

Tools > Templates > Other > Special File, Duplicate, Rename to Special File #2. File > New > Other > Special File now shows an older time, not current time.

Restart, File > New > Other > Special File; now throws an exception, because its content is not a copy of the original layer entry:

    <fileobject name="special_1">
        <attr name="SystemFileSystem.localizingBundle" serialvalue="aced0005737200316f72672e6f70656e6964652e66696c6573797374656d732e4d756c746946696c654f626a65637424566f696456616c7565d9ec9c94d5fd3ca40c0000787077040000000178"/>
        <attr name="displayName" stringvalue="Special File #2"/>
        <attr name="instantiatingIterator" newvalue="test20169.SpecialWizardIterator"/>
        <attr name="template" boolvalue="true"/>
        <attr name="templateWizardURL" urlvalue="nbresloc:/test20169/special.html"/>

Includes unnecessary SystemFileSystem.localizingBundle, and instantiatingIterator is using newvalue (on a class with no no-arg ctor) rather than methodvalue.
Comment 9 Jaroslav Tulach 2010-04-28 08:20:06 UTC
Jesse, your example module shows bug in favorites implementation, not in FileUtil.copyAttributes. The templates dialog does its own manual copying:

    private static void setTemplateAttributes(FileObject fo, HashMap<String, Object> attributes) throws IOException {
        for (Entry<String, Object> entry : attributes.entrySet()) {
            // skip localizing bundle for custom templates
            if (TEMPLATE_LOCALIZING_BUNDLE_ATTRIBUTE.equals (entry.getKey ())) {
            fo.setAttribute(entry.getKey(), entry.getValue());

Reassigning to favorites module.
Comment 10 Martin Entlicher 2010-10-07 12:42:04 UTC
TemplatesPanel need to use FileUtil.copyAttributes() instead of manually copying the attributes.
Comment 11 Martin Entlicher 2010-10-07 14:24:57 UTC
Fixed by changeset:   178963:3405348d2adc
Comment 12 Quality Engineering 2010-10-08 03:22:24 UTC
Integrated into 'main-golden', will be available in build *201010080000* on (upload may still be in progress)
Log: #20169 Use FileUtil.copyAttributes() instead of manually copying the file attributes.