This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 206885 - Wizards do not generate code according to current API idioms
Summary: Wizards do not generate code according to current API idioms
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Templates (show other bugs)
Version: 7.1
Hardware: PC Linux
: P2 normal (vote)
Assignee: Jesse Glick
URL:
Keywords: REGRESSION
Depends on: 70917 208677
Blocks: 204615
  Show dependency tree
 
Reported: 2012-01-03 23:22 UTC by Jesse Glick
Modified: 2012-02-21 18:10 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2012-01-03 23:22:46 UTC
Due to the fix of bug #204615, getDependencyVersion for a module that already includes deps on some module supplies the dependency version, not the module list version. In the case of adding an action, if the deps on org.openide.{awt,util} are old, an old-style CallableSystemAction will then be created instead of using @ActionRegistration.

In the short term, the patch to gDV should be rolled back. For a full fix, probably the NbModuleProvider API needs to differentiate between _current_ version and _potential_ version. This only applies to the Ant harness, since for the Maven harness dependency versions are generally managed externally and correspond to a specific release; a fix of bug #70917 would remove the distinction for the Ant harness too.
Comment 1 Jesse Glick 2012-02-08 04:08:57 UTC
core-main #d3a859b2a862
Comment 2 Jesse Glick 2012-02-08 04:14:47 UTC
Not sure what effect if any this fix has on Jackpot scripts as mentioned in bug #204615, but making wizards work correctly is surely a higher priority. Can this be a 71patch1-candidate?
Comment 3 Marian Mirilovic 2012-02-08 08:39:22 UTC
(In reply to comment #2)
> Not sure what effect if any this fix has on Jackpot scripts as mentioned in bug
> #204615, but making wizards work correctly is surely a higher priority. Can
> this be a 71patch1-candidate?

Sure, as you reported the bug I think you can also verify and go ahead with integration into releases.
Comment 4 Jesse Glick 2012-02-08 16:57:13 UTC
Verified by opening trunk sources of the diff module in 7.1 and creating a new "Action" - uses old CallableSystemAction idiom; same in a dev build with this fix uses new @ActionRegistration idiom.
Comment 5 Jesse Glick 2012-02-08 18:13:30 UTC
releases #d91e5a9b2fa4
Comment 6 Quality Engineering 2012-02-09 02:36:46 UTC
Integrated into 'releases', will be available in build *201202082200* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/d91e5a9b2fa4
User: Jesse Glick <jglick@netbeans.org>
Log: #206885: Wizards do not generate code according to current API idioms
Comment 7 Tomas Danek 2012-02-15 13:30:29 UTC
verified in 7.1.1 rc1 - new action in module (in dev platform) is created with @ActionRegistration