This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 210691 - Actions in the history tab do not work properly
Summary: Actions in the history tab do not work properly
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Stupka
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2012-04-04 12:07 UTC by Tomas Stupka
Modified: 2012-04-14 09:45 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
changes in versioning spi (20.10 KB, patch)
2012-04-04 16:33 UTC, Tomas Stupka
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Stupka 2012-04-04 12:07:41 UTC
there are scenarios when the action in the history do not work properly:

- multiselection 
  - some actions should work also if more revisions are selected - e.g. delete from local history
  - also that the history provider should be able to, depending on the selection, decide if an action is enabled or not

- when only 1 file from a multifile node (e.g. form) is selected than the invoked action will be applied for all files from such a node
Comment 1 Tomas Stupka 2012-04-04 16:21:34 UTC
suggested fix would be to ensure that if a ContextAwareAction is provided via VCSHistoryProvider.HistoryEntry.getActions() it will be initialized with a context containing the nodes from the history tab. Those nodes then would contain the relevant HistoryEntry and files for witch the actions is supposed to be invoked.
Comment 2 Tomas Stupka 2012-04-04 16:33:41 UTC
Created attachment 117824 [details]
changes in versioning spi

described suggested behavior in javadoc and tests in versioning and versioning.core spi
Comment 3 Tomas Stupka 2012-04-04 16:37:53 UTC
please review. thanks.
Comment 4 Tomas Stupka 2012-04-11 12:08:30 UTC
in case no objection is raised, then will integrate tomorrow
Comment 5 Tomas Stupka 2012-04-13 10:06:21 UTC
fixed core-main #ebf60d27d589
Comment 6 Tomas Stupka 2012-04-13 10:08:06 UTC
actually fixed in core-main #1177bad8e9a2
Comment 7 Quality Engineering 2012-04-14 09:45:20 UTC
Integrated into 'main-golden', will be available in build *201204140400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1177bad8e9a2
User: Tomas Stupka <tstupka@netbeans.org>
Log: Issue #210691 - Actions in the history tab do not work properly