This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 219745 - nbbuild/misc/i18ncheck.pl : false warning for quotes in comments
Summary: nbbuild/misc/i18ncheck.pl : false warning for quotes in comments
Status: REOPENED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 7.3
Hardware: PC Solaris
: P3 normal (vote)
Assignee: pgebauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 10:48 UTC by Alexander Simon
Modified: 2012-11-12 10:25 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2012-10-09 10:48:01 UTC 
Script i18ncheck.pl detects i18n problem in the line:

int i = 0; /* false warning "for quotes" in comment */
Comment 1 Masaki Katakai 2012-11-12 03:19:30 UTC 
Hi Alexander,

Thank you for filing issue. But could you tell me more detail?

Which place? I don't understand how we have to fix it.

marked it as INCOMPETE.
Comment 2 Alexander Simon 2012-11-12 06:51:38 UTC 
(In reply to comment #1)
> Hi Alexander,
> 
> Thank you for filing issue. But could you tell me more detail?
> 
> Which place? I don't understand how we have to fix it.
> 
> marked it as INCOMPETE.
Hi Masaki,

CND team uses nbbuild/misc/i18ncheck.pl script to check i18n problem in the CND code. Script is ran in each build on CND husdson.

Script produces false positive warning if java code contains the mentioned string.
Comment 3 Masaki Katakai 2012-11-12 07:41:58 UTC 
Thank you Alexander!

Do you know which file and line number is detected as warning?
Comment 4 Alexander Simon 2012-11-12 08:20:48 UTC 
There is no such code in CND sources.
Because i18n warning it is P2 for CND team.
We did a workaround. See change set:

changeset 064c12403bcd in cnd-main ((none))
details: http://hg.netbeans.org/cnd-main/rev/064c12403bcd
description:
	i18n workaround
Comment 5 Masaki Katakai 2012-11-12 08:41:20 UTC 
Thank you!

So do you mean this workaround should be merged into other place ?

In nblocalization project, we're working just translation of NetBeans Platform and IDE. If this fix should be merged into base NetBeans product, I think you need to file bug report to cnd, not nblocalization.
Comment 6 Alexander Simon 2012-11-12 10:09:38 UTC 
(In reply to comment #5)
> Thank you!
> 
> So do you mean this workaround should be merged into other place ?
> 
> In nblocalization project, we're working just translation of NetBeans Platform
> and IDE. If this fix should be merged into base NetBeans product, I think you
> need to file bug report to cnd, not nblocalization.

IMHO it is a bug in nbbuild/misc/i18ncheck.pl.
I expect that the script will be fixed an will not produce false positive warnings on such code.
Comment 7 Masaki Katakai 2012-11-12 10:24:01 UTC 
OK, now I understand. Thank you very much!

Let's move to another component for nbbuild/misc/i18ncheck.pl issue.