This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220309 - INFO [org.netbeans.spi.lexer.MutableTextInput]: !!WARNING!! Missing READ-LOCK when accessing TokenHierarchy
Summary: INFO [org.netbeans.spi.lexer.MutableTextInput]: !!WARNING!! Missing READ-LOCK...
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Editor (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Alexander Simon
URL:
Keywords:
: 219894 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-17 16:07 UTC by Vladimir Voskresensky
Modified: 2013-05-15 12:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2012-10-17 16:07:35 UTC
Please, evaluate if fix should be done on Editor of client side when create files from template (add New File).

INFO [org.netbeans.spi.lexer.MutableTextInput]: !!WARNING!! Missing READ-LOCK when accessing TokenHierarchy: input-source:org.netbeans.modules.editor.NbEditorDocument@1dcf4b6, mimeType='text/x-c++', kitClass=null, length=201, version=34, file=null
java.lang.Exception
        at org.netbeans.lib.lexer.TokenHierarchyOperation.ensureReadLocked(TokenHierarchyOperation.java:397)
        at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequenceList(TokenHierarchyOperation.java:434)
        at org.netbeans.api.lexer.TokenHierarchy.tokenSequenceList(TokenHierarchy.java:229)
        at org.netbeans.modules.editor.indent.TaskHandler$MimeItem.indentRegions(TaskHandler.java:433)
        at org.netbeans.modules.editor.indent.spi.Context.indentRegions(Context.java:258)
        at org.netbeans.modules.cnd.editor.reformat.Reformatter.reformat(Reformatter.java:104)
        at org.netbeans.modules.editor.indent.TaskHandler$MimeItem.runTask(TaskHandler.java:548)
        at org.netbeans.modules.editor.indent.TaskHandler.runTasks(TaskHandler.java:316)
        at org.netbeans.modules.editor.indent.IndentImpl.reformat(IndentImpl.java:357)
        at org.netbeans.modules.editor.indent.api.Reformat.reformat(Reformat.java:154)
        at org.netbeans.modules.cnd.source.SourceAbstractDataLoader$CndFormat.createFromTemplate(SourceAbstractDataLoader.java:270)
        at org.openide.loaders.MultiDataObject.handleCreateFromTemplate(MultiDataObject.java:831)
        at org.netbeans.modules.cnd.source.SourceDataObject.handleCreateFromTemplate(SourceDataObject.java:135)
        at org.openide.loaders.DataObject$CreateAction.run(DataObject.java:1438)
        at org.openide.loaders.DataObjectPool$1WrapAtomicAction.run(DataObjectPool.java:261)
        at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:127)
        at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:607)
        at org.openide.loaders.DataObjectPool.runAtomicAction(DataObjectPool.java:273)
        at org.openide.loaders.DataObject.invokeAtomicAction(DataObject.java:910)
        at org.openide.loaders.DataObject.createFromTemplate(DataObject.java:842)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl$2.run(MakeProjectGeneratorImpl.java:379)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl$CreateMainParams.doPostProjectCreationWork(MakeProjectGeneratorImpl.java:400)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl$CreateMainParams.access$000(MakeProjectGeneratorImpl.java:389)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl$1.run(MakeProjectGeneratorImpl.java:248)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl.createProject(MakeProjectGeneratorImpl.java:257)
        at org.netbeans.modules.cnd.makeproject.MakeProjectGeneratorImpl.createProject(MakeProjectGeneratorImpl.java:179)
        at org.netbeans.modules.cnd.makeproject.ui.wizards.NewMakeProjectWizardIterator.instantiate(NewMakeProjectWizardIterator.java:453)
        at org.netbeans.modules.cnd.makeproject.ui.wizards.NewMakeProjectWizardIterator.instantiate(NewMakeProjectWizardIterator.java:345)
        at org.openide.loaders.TemplateWizard$InstantiatingIteratorBridge.instantiate(TemplateWizard.java:1044)
        at org.openide.loaders.TemplateWizard.handleInstantiate(TemplateWizard.java:605)
        at org.openide.loaders.TemplateWizard.instantiateNewObjects(TemplateWizard.java:439)
        at org.openide.loaders.TemplateWizardIterImpl.instantiate(TemplateWizardIterImpl.java:253)
        at org.openide.loaders.TemplateWizardIteratorWrapper$ProgressInstantiatingIterator.instantiate(TemplateWizardIteratorWrapper.java:180)
        at org.openide.WizardDescriptor.callInstantiateOpen(WizardDescriptor.java:1573)
        at org.openide.WizardDescriptor.callInstantiate(WizardDescriptor.java:1517)
        at org.openide.WizardDescriptor.access$2100(WizardDescriptor.java:89)
        at org.openide.WizardDescriptor$Listener$2$1.run(WizardDescriptor.java:2157)
        at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1454)
        at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2036)
Comment 1 markiewb 2012-10-18 15:19:12 UTC
A similar error has already been fixed. Maybe you can adopt the solution?
Have a look at http://netbeans.org/bugzilla/show_bug.cgi?id=220312#c1
Comment 2 Dusan Balek 2012-10-19 07:06:06 UTC
Reformat.reformat(...) should be called under the document lock as requested by the Reformat Javadoc.
Comment 3 Vladimir Voskresensky 2012-10-19 07:35:07 UTC
ok. thanks
Comment 4 Alexander Simon 2012-10-19 08:16:13 UTC
(In reply to comment #2)
> Reformat.reformat(...) should be called under the document lock as requested by
> the Reformat Javadoc.
CND do exactly this, line 270 in SourceAbstractDataLoader$CndFormat.createFromTemplate()

                        reformat.lock();
                        try {
                            reformat.reformat(0, doc.getLength());
                        } finally {
                            reformat.unlock();
                        }
Comment 5 Alexander Simon 2012-10-19 09:21:46 UTC
fixed, change set:
http://hg.netbeans.org/cnd-main/rev/faa0c1eb6952
Comment 6 Quality Engineering 2012-10-20 01:29:31 UTC
Integrated into 'main-golden', will be available in build *201210200002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/faa0c1eb6952
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #220309 INFO [org.netbeans.spi.lexer.MutableTextInput]: !!WARNING!! Missing READ-LOCK when accessing TokenHierarchy
Comment 7 Egor Ushakov 2013-05-15 12:57:06 UTC
*** Bug 219894 has been marked as a duplicate of this bug. ***