This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
see issue 193981, ant projects now allow setting project.licensePath property in nbproject/project.properties that points to a file in project space (absolute path) We will need some UI in Project Properties that would allow 1. setting a license from the current list in IDE 2. allow setting a reference to file in project space 3. allow creating a license template file in project space.
Created attachment 132283 [details] api module changes, includes api and implementation
Created attachment 132284 [details] j2se project implementation
Created attachment 132285 [details] maven projects implementation
please review this new api to create license header editing customizer panel for ant and maven projects (or anything else depending on projects.ant)
API looks well to me. few details: MF01 - first patch is uncompilable now: DefaultComboBoxModel<GlobalItem> MF02 - UI panel left, top paddings are not consistent with the rest of project customizer UI panels MF03 - no Common Annotation usage j2se client: MF04 - J2SECompositePanelProvider#setProjectLicenseLocation handles wrong the <code>null<code> value BTW, relative project.licensePath didn't work to me - issue #227139.
thanks for the review, will implement MF01-04 and integrate shortly
http://hg.netbeans.org/core-main/rev/83544a84772b
Integrated into 'main-golden', will be available in build *201303132300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/83544a84772b User: Milos Kleint <mkleint@netbeans.org> Log: #226773, #226774 provide ui for selecting license header panel in customizers for maven and j2se projects
Milos, why was org.netbeans.spi.project.support.ant.ui.CustomizerUtilities put into ant.project module instead of projectuiapi when it is used by all project types - Ant, Maven, HTML5, PHP?
(In reply to comment #9) > Milos, why was org.netbeans.spi.project.support.ant.ui.CustomizerUtilities put > into ant.project module instead of projectuiapi when it is used by all project > types - Ant, Maven, HTML5, PHP? well, likely because noone objected at apireview time. :) I've just picked the lowest common denominator I could think of and ant support is effectively used by maven because of higher level dependencies. Do you have a project type case that actually has to add the ant project dependency?
No, I do not have one. HTML5 project type is using Ant - in order to build PhoneGap applications Ant script is used internally. But I'm surprised to hear that Maven is using Ant. It's not a big deal - I was just surprised.