This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227244 - Disable upload on save when updating from versioning
Summary: Disable upload on save when updating from versioning
Status: NEW
Alias: None
Product: php
Classification: Unclassified
Component: FTP Support (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-09 18:13 UTC by crazyfacka
Modified: 2013-03-11 11:11 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description crazyfacka 2013-03-09 18:13:54 UTC
When performing an update to the whole project, if upload on save is selected for the PHP project, all updated files will be uploaded to the server, discarding changes made in the meantime by fellow workers.

I would like to suggest the inclusion of something like "Upload on Save (except when using versioning)" or changing its name to "Upload on Change" and create a true "Upload on Save" :)
Comment 1 Tomas Mysik 2013-03-11 09:33:16 UTC
(In reply to comment #0)
> When performing an update to the whole project, if upload on save is selected
> for the PHP project, all updated files will be uploaded to the server,
> discarding changes made in the meantime by fellow workers.

Well, mixing SCM and FTP is not a good idea, ever.

@ovrabec: Ondro, is it possible to recognize which event comes from versiong support?

Thanks.
Comment 2 Ondrej Vrabec 2013-03-11 09:55:01 UTC
(In reply to comment #1)
> @ovrabec: Ondro, is it possible to recognize which event comes from versiong
> support?
Versioning - in some cases such as versioning update in NetBeans, definitely not externally using other tools - can say what files really changed. But AFAIK PHP catches events coming from FileSystem and not Versioning (VCS does not fire any such events).
PHP could probably catch "beforeChange" and "afterChange/Delete/Create" events the same way versioning does. The "beforeChange" event is fired from FS when a file is being saved by NB (using save action, refactoring etc.) and the "after" events are fired either when the save finishes or an external change (such as VCS update) is detected. So PHP may call copy-on-save only if a "beforeChange" event was delivered before. However i am not sure how reliable it would be, plus you would probably need to depend on other masterfs SPIs (see masterfs...ProvidedExtensions).
Comment 3 Tomas Mysik 2013-03-11 11:11:09 UTC
Thanks a lot Ondro, I will look at it.