This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227572 - Patch for: New code folding should display "12 lines" instead of "12 line(s)"
Summary: Patch for: New code folding should display "12 lines" instead of "12 line(s)"
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Code folding (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Svata Dedic
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-03-17 00:15 UTC by markiewb
Modified: 2013-06-03 21:22 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Shows the current nonnatural state (17.66 KB, image/png)
2013-03-17 00:15 UTC, markiewb 		Details
Proposed patch (614 bytes, patch)
2013-04-13 21:39 UTC, markiewb 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-03-17 00:15:52 UTC 
Created attachment 132700 [details]
Shows the current nonnatural state

New code folding was introduced by http://netbeans.org/bugzilla/show_bug.cgi?id=226413

ACTUAL:
Now collapsed foldings show the number of lines in the format "x line(s)". The parentheses look strange IMHO 

EXPECTED:
Collapsed foldings show the number of lines in the more "natural" format "1 line", "2 lines".. "n lines" - please use the choice feature of Message.format "...{0,choice,1#line|1<lines}"
Comment 1 markiewb 2013-04-13 21:39:13 UTC 
Created attachment 133487 [details]
Proposed patch

I like to propose the following patch to solve the issue. The simple patch makes use of the choice option of MessageFormat to show the correct ending.

@NB-Dev: Please review, discuss and commit (if it is worth). Thank you
Comment 2 Svata Dedic 2013-04-19 14:33:18 UTC 
Fixed in rev. http://hg.netbeans.org/jet-main/rev/d0d86a6ec395
Comment 3 Quality Engineering 2013-04-21 02:18:40 UTC 
Integrated into 'main-golden', will be available in build *201304202301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d0d86a6ec395
User: Svata Dedic <sdedic@netbeans.org>
Log: #227572: choiceformat use for more natural line count message