This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227893 - Add 'Compile Error' Warning before checkin
Summary: Add 'Compile Error' Warning before checkin
Status: NEW
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Assignee: Ondrej Vrabec
Depends on:
Reported: 2013-03-25 10:07 UTC by tomzi
Modified: 2014-06-05 12:20 UTC (History)
2 users (show)

See Also:
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description tomzi 2013-03-25 10:07:17 UTC
It would help to have Netbeans check if there is a compile error of the code I currently want to checkin. 

I would suggest to have a 'Warning' in the 'Commit' Dialog. It should be possible to checkin anyway, I guess. But at least you could abort the commit, to check the compilation issue.

Usually other team members tend to be pretty 'cannibalistic' if you checkin in non-compiling code, thus it would be helpful to have Netbeans check before checkin :)
Comment 1 Ondrej Vrabec 2013-03-25 10:18:25 UTC
AFAIK Honza Lahoda did something in this area, maybe he knows more.
Comment 2 Jan Lahoda 2013-03-26 13:43:15 UTC
I unfortunately did not have time to pursue the idea of showing warnings in the commit dialog.

Regarding a warning about incompilable source code: makes sense to me. It is not difficult to find out whether something contains an error (org.netbeans.modules.parsing.spi.indexing.ErrorsCache.isInError). There may be some challenges anyway, e.g. finding out the scope on which the check for errors should be performed (the current changes might introduce error in existing files, that are not being committed). Also, a lot of small trouble can be expected (broken caches leading to incorrect warnings about errors, etc.) - but I guess these could sorted out as they would revealed.
Comment 3 tomzi 2013-03-27 07:20:01 UTC
I don't really know what is actually all included in 'Errors', but for example, things like FindBugs, Checkstyle... should not be included or configurable. It's really most important to not break the compilation of the code for all other team members.