This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229019 - Move the uihandler and lib.uihandler modules to platform
Summary: Move the uihandler and lib.uihandler modules to platform
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Logger (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2013-04-25 14:32 UTC by Jan Horvath
Modified: 2013-05-11 02:32 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
The proposed changes (13.66 KB, patch)
2013-04-29 15:07 UTC, Martin Entlicher 		Details | Diff
The proposed changes with branding (81.50 KB, patch)
2013-05-08 22:22 UTC, Martin Entlicher 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Horvath 2013-04-25 14:32:48 UTC 
Move the uihandler and lib.uihandler modules to the platform cluster so it can be used in other products.
Comment 1 Martin Entlicher 2013-04-29 14:19:09 UTC 
The tests were fixed by changeset:   252239:02389b497df2
http://hg.netbeans.org/core-main/rev/02389b497df2
Comment 2 Martin Entlicher 2013-04-29 15:07:10 UTC 
Created attachment 133941 [details]
The proposed changes
Comment 3 Martin Entlicher 2013-04-29 15:19:37 UTC 
Please review the proposed changes - transfer of lib.uihandler and uihandler modules from nb cluster to platform cluster.
Javadoc was added to the public classes and an ordinary public API was made from lib.uihandler module.

Two public classes in lib.uihandler are not used anywhere:
MultiPartHandler and ProjectOp
They are referenced from tests only.
They are used in tests only. I'm not sure if we want to just delete these classes, therefore I've made them package-private for now. The appropriate tests need to be probably commented out. If someone has an idea about the purpose of these classes, please suggest what we should do with them.

nbbuild/build.properties and nbbuild/cluster.properties is adjusted accordingly.
Comment 4 Quality Engineering 2013-05-02 14:11:15 UTC 
Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/02389b497df2
User: mentlicher@netbeans.org
Log: #229019: Tests fixed.
Comment 5 Martin Entlicher 2013-05-08 22:22:21 UTC 
Created attachment 134236 [details]
The proposed changes with branding

Since we move NetBeans IDE-specific stuff to platform, I've added branding of all NetBeans-specific functionaliy (such as logger names, URLs, etc.).
The changes are described in apichanges.xml and arch.xml is also modified.
Tests are adapted for the change as well.
bugzilla.exceptionreporter bridge module is adapted to the changed bug tracking accessor class.
Comment 6 Martin Entlicher 2013-05-09 11:48:06 UTC 
If there are no comments on this, I'd like to push the change on Friday. Thanks.
Comment 7 Martin Entlicher 2013-05-10 15:02:35 UTC 
Pushed as http://hg.netbeans.org/core-main/rev/cf687933dc7f
Comment 8 Quality Engineering 2013-05-11 02:32:40 UTC 
Integrated into 'main-golden', will be available in build *201305102300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/cf687933dc7f
User: mentlicher@netbeans.org
Log: #229019: lib.uihandler and uihandler modules are moved from 'nb' cluster to 'platform'. NetBeans-specific messages, URLs and logger names are branded.