This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229108 - Patch for: "Diff to revision"-dialog doesn't resize properly
Summary: Patch for: "Diff to revision"-dialog doesn't resize properly
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-04-27 16:04 UTC by markiewb
Modified: 2013-07-23 22:01 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
shows the issue (81.98 KB, image/png)
2013-04-27 16:04 UTC, markiewb 		Details
Proposed patch (4.28 KB, patch)
2013-04-27 16:13 UTC, markiewb 		Details | Diff
Patch in action (52.82 KB, image/png)
2013-04-27 16:13 UTC, markiewb 		Details
Patch in action - shows the resizing behaviour (118.83 KB, image/png)
2013-04-27 16:14 UTC, markiewb 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-04-27 16:04:35 UTC 
Created attachment 133876 [details]
shows the issue

ACTUAL the dialog content doesn't resize on horizontal resize - see screenshot

EXPECTED the dialog content resizes properly on horizontal resize
Comment 1 markiewb 2013-04-27 16:13:21 UTC 
Created attachment 133877 [details]
Proposed patch

I like to propose a patch to solve this issue. The patch contains only some alignment/resizing modifications. Now it resolves properly.

Please have a look at it.
Comment 2 markiewb 2013-04-27 16:13:33 UTC 
Created attachment 133878 [details]
Patch in action
Comment 3 markiewb 2013-04-27 16:14:47 UTC 
Created attachment 133879 [details]
Patch in action - shows the resizing behaviour
Comment 4 Ondrej Vrabec 2013-04-28 16:50:40 UTC 
thanks for the patch. pushed as http://hg.netbeans.org/core-main/rev/4ac01f09eb7a
Comment 5 Quality Engineering 2013-05-02 14:10:58 UTC 
Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/4ac01f09eb7a
User: Benno Markiewicz <markiewb@netbeans.org>
Log: #229108 - Diff to revision-dialog doesn't resize properly
Comment 6 markiewb 2013-07-23 22:01:01 UTC 
Verified in 201307222300