This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229351 - API change: Move CustomizerProvider2 to Project UI API
Summary: API change: Move CustomizerProvider2 to Project UI API
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Projects UI (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Petr Somol
URL:
Keywords: API
: 154676 229384 (view as bug list)
Depends on:
Blocks: 229161 229385
  Show dependency tree
 
Reported: 2013-05-04 19:44 UTC by Petr Somol
Modified: 2013-05-17 07:30 UTC (History)
7 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Changes in all affected modules (13.16 KB, patch)
2013-05-04 19:44 UTC, Petr Somol
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Somol 2013-05-04 19:44:23 UTC
Created attachment 134107 [details]
Changes in all affected modules

Currently there exists the interface CustomizerProvider in projectuiapi, and its later extension CustomizerProvider2 with more limited scope, located currently in java.api.common. In another API review we consider extending CustomizerProvider2 further by defining CustomizerProvider3 (see Issue #229161).

CustomizerProvider2 is now seen as being potentially usable in more wider context than before, and a request to move it to projectuiapi has been made. Moving it to projectuiapi sounds logical in view of the fact that CustomizerProvider already resides there. The move would not have serious consequences, it would just need to adjust references to CustomizerProvider2 in several project implementations. I am attaching a changeset that lists the necessary changes. The current location of CustomizerProvider2 would remain in existence, marked as Deprecated, and not used anymore from anywhere.

Please, David Konecny, add more details and reasoning why this is a desirable change.

The decision about this change would affect the implementation of API change proposed in Issue #229161 which is needed in 7.4 timeframe.
Comment 1 David Konecny 2013-05-05 19:03:04 UTC
Great, thanks for doing this Petr! I'm getting an error when trying to open the attachment but once Bugzilla works again I will review the diff.

From issue 229130:

"For example CSS Preprocessors API could be simplified and just call this API to open project properties with CSS Customizer panel preselected when CSS preprocessor is not properly configured in project type.

Another example might be browser switcher popup which in the latest UI specification has "Configure PhoneGap" action and which will likely need to open Project customizer with PhoneGap panel pre-selected."

From issue 154676:

"For instance, in the C/C++ module if a compiler is not set it would be useful to open the "Project Properties" dialog in the appropriate category."
Comment 2 David Konecny 2013-05-05 19:04:16 UTC
*** Bug 154676 has been marked as a duplicate of this bug. ***
Comment 3 Jan Becicka 2013-05-06 10:05:50 UTC
*** Bug 229384 has been marked as a duplicate of this bug. ***
Comment 4 Jan Becicka 2013-05-06 10:17:56 UTC
Patch is OK
Comment 5 David Konecny 2013-05-08 23:31:14 UTC
Yeah, patch is good. Thanks.
Comment 6 Petr Somol 2013-05-13 08:23:28 UTC
seems there is agreement on this, going to integrate today.
Comment 7 Petr Somol 2013-05-13 08:47:16 UTC
fixed in jetmain
http://hg.netbeans.org/jet-main/rev/ff0e1f104ce2
Comment 8 David Konecny 2013-05-15 01:39:40 UTC
Awesome, thanks for doing that Petr!
Comment 9 Petr Jiricka 2013-05-16 20:49:27 UTC
Still not in main-silver :-(
Comment 10 David Konecny 2013-05-16 21:23:51 UTC
I was wondering about the same few times - why the fix has not propagated yet from jet-main anywhere else? Does your push-jet-main hudson job work?
Comment 11 Jan Becicka 2013-05-17 06:28:29 UTC
(In reply to comment #10)
> I was wondering about the same few times - why the fix has not propagated yet
> from jet-main anywhere else? Does your push-jet-main hudson job work?

Nothing wrong with push-jet-main. But last successful jet-main build was on May 11.
Comment 12 Petr Somol 2013-05-17 07:30:32 UTC
today jet-main produced first successful build after 6 days, so the change should propagate soon at last