This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233577 - Missing toolbar icons / toolbar items for Git
Summary: Missing toolbar icons / toolbar items for Git
Status: RESOLVED DUPLICATE of bug 213266
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 09:44 UTC by Trejder
Modified: 2013-07-29 13:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Attachement #1: Netbeans - Missing icons in Git toolbar items (14.70 KB, image/png)
2013-07-29 09:44 UTC, Trejder
Details
Attachement #1: Netbeans - Missing Git toolbar items (14.70 KB, image/png)
2013-07-29 09:46 UTC, Trejder
Details
Attachement #2: Netbeans - Missing icons in Git toolbar items (43.67 KB, image/png)
2013-07-29 09:47 UTC, Trejder
Details
Screenshot from NetBeans IDE Dev Build 201307282300 (34.17 KB, image/png)
2013-07-29 10:11 UTC, Trejder
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Trejder 2013-07-29 09:44:32 UTC
Created attachment 137930 [details]
Attachement #1: Netbeans - Missing icons in Git toolbar items

On some installations of Netbeans (in this example: 7.3 Build 201306052037) many Git-related items are represented with a strange strings in button list of buttons available for adding to toolbar. And, after actually adding them to a toolbar, they're represented by only text, without icon. See attachement #1 ("Netbeans - Missing icons in Git toolbar items.png").

On some other installations of Netbeans (in this example: 7.3 Build 201302132200) this string-like items in button list are all gone and number of Git-related buttons, user can add to a toolbar is very limited. See attachement #2 ("Netbeans - Missing Git toolbar items.png").

More details in this Stack Overflow question: http://stackoverflow.com/questions/16667618/missing-obvious-buttons-for-git-in-netbeans
Comment 1 Trejder 2013-07-29 09:46:51 UTC
Created attachment 137931 [details]
Attachement #1: Netbeans - Missing Git toolbar items
Comment 2 Trejder 2013-07-29 09:47:40 UTC
Created attachment 137932 [details]
Attachement #2: Netbeans - Missing icons in Git toolbar items
Comment 3 Ondrej Vrabec 2013-07-29 09:54:51 UTC
Please try a latest dev build and make a screenshot there: http://bits.netbeans.org/download/trunk/nightly/latest/
Comment 4 Trejder 2013-07-29 10:11:50 UTC
Created attachment 137933 [details]
Screenshot from NetBeans IDE Dev Build 201307282300

Screenshot from: "NetBeans IDE Dev (Build 201307282300)".

Situation even worse: Can't add "Push/Pull" at all to the toolbar, as these command are not available in buttons list, neither as full-icon buttons, nor as text-only buttons.
Comment 5 Ondrej Vrabec 2013-07-29 10:18:08 UTC
The correct state should be: only the actions with icons are displayed. You can add only a limited set of actions to toolbar and pull/push is not among of them because it's an advanced action and we do not have icon for it. They are simply not supposed to be displayed in the toolbar.
Passing to window system to evaluate: why are the other actions displayed when they have no icon? BTW, i am unable to reproduce in dev build, i can see only the actions with icons.
Comment 6 Trejder 2013-07-29 10:33:53 UTC
As I wrote in linked Stack Overflow question, I'm using Push and Pull nearly as often as using Commit. So, I don't understand, how can that be an "advanced function". There's no Git without Push / Pull (at least for me). And the need to dig this EVERY time from menu: Team > Git > Remote > Push is strange and very uncomfortable for me.

So, when you're saying "we don't want Push in toolbar", I don't know for who you're talking for. But certainly for me and others, like me, for whom not having Push / Pull in toolbar is very wrong.

Notice, that you have to dig-out FOR level menu-submenu to get to this very popular item. So, I really don't understand how it can be "not wanted in toolbar".

Not mentioning, that it is USER, not a DEV team to decide, what USER want to have or don't want to have in toolbar.

BTW: Can you explain, how it is possible, that "Push" / "Pull" commands are unwanted in toolbar for Git, while in the same time "Commit" button (which acts for the nearly the same purpose) for Subversion / SVN toolbar is very wanted and can be added to the toolbar? In the very basic purpose Git's Commit + Push acts like SVN's Commit. The results are exactly the same -- local changes are stored in the remote repo.
Comment 7 Ondrej Vrabec 2013-07-29 10:42:06 UTC
You're more than welcome to file a RFE that would bring these actions to the toolbar. I don't care if they are present in the toolbar or not. As you correctly pointed out you're the one who decides that. I am simply saying the missing action in the toolbar is not a bug but an enhancement request. This issue is about incorrectly displayed textual actions in the toolbar while they shouldn't be displayed.
Comment 8 Trejder 2013-07-29 10:46:17 UTC
OK, thanks. So I feel out enhancement request and leave this bug open, as it seems I've discovered something wrong by occasion.
Comment 9 Stanislav Aubrecht 2013-07-29 13:55:14 UTC

*** This bug has been marked as a duplicate of bug 213266 ***