This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 235675 - MavenSourceJavadocAttacher produces file:// urls, not the expected jar:// urls
Summary: MavenSourceJavadocAttacher produces file:// urls, not the expected jar:// urls
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 7.4
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Milos Kleint
URL:
Keywords: 7.4_HR_FIX
Depends on:
Blocks:
 
Reported: 2013-09-09 08:45 UTC by Milos Kleint
Modified: 2013-09-11 13:53 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2013-09-09 08:45:41 UTC 
MavenSourceJavadocAttacher produces file:// urls but these result exception down the road (exception reporter is down now, but is reproducible with 20130904 build.)

SourceJavadocAttacherImplementation.Definer apparently expects jar:// style protocol urls, but it's not apparent from the api signatures.
Comment 1 Milos Kleint 2013-09-09 08:53:51 UTC 
http://hg.netbeans.org/core-main/rev/61f321cb569d

musilt2: please consider if this is to be backported to 74 branch. without the fix the "Download" button in Attach Javadoc/Attach sources dialogs is a noop (with exception thrown)
Comment 2 Quality Engineering 2013-09-10 05:00:39 UTC 
Integrated into 'main-silver', will be available in build *201309100337* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/61f321cb569d
User: Milos Kleint <mkleint@netbeans.org>
Log: #235675 find the source/javadoc root fileobject within the source/javadoc jar found and only return it's url, not the jar file's url
Comment 3 Tomas Danek 2013-09-10 14:49:30 UTC 
I've verified that fix works for downloading source. ...but I cannot figure out how to test it for downloading javadoc?? (anyway fix seems to be generic for javadoc and sources)

I'm ok with backport to 7.4 in general..
Comment 4 Milos Kleint 2013-09-11 13:53:19 UTC 
http://hg.netbeans.org/releases/rev/750f60e065c0