This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 245046 - Clarify title of versioning Update dialogue
Summary: Clarify title of versioning Update dialogue
Status: REOPENED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 8.0
Hardware: All All
: P3 normal with 1 vote (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 23:27 UTC by ulfzibis
Modified: 2014-08-06 07:00 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ulfzibis 2014-06-13 23:27:25 UTC
[ JDK VERSION : 1.7.0_45 ]

STEPS:
   * Mark single single file(s)/folder(s)
   * Invoke Mercurial->Update

ACTUAL:
   In contrast to users expectation, all files of same repository, even if
effecting other projects, are updated.

EXPECTED:
   There should be a warning that all files of same repository, even if
affecting other projects, are updated when proceeding. Same for
Mercurial->Branches->SwitchTo. Maybe this effect is also valid for other
versioning systems.
Comment 1 Ondrej Vrabec 2014-06-14 06:29:34 UTC
AFAIK there's already a warning when the update is about to overwrite your local changes (i.e. you edit a file and then do Merc -> Update on another file). Besides that i don't see a reason to having such a warning. You're not gonna loose any work, you just might be surprised that mercurial (and other distributed systems) work on the whole repository in some cases.
I do understand it's something users coming from Subversion do not expect but that's the way hg works.
Comment 2 ulfzibis 2014-08-02 11:46:44 UTC
(In reply to Ondrej Vrabec from comment #1)
> Besides that i don't see a reason to having such a warning.

But it can be seen as a defect that Mercurial->Update on single file is enabled in GUI at all.

> You're not gonna loose any work, you just might be surprised that mercurial
> (and other distributed systems) work on the whole repository in some cases.
Imagine user has edited referring file and WC is on rev 100. Erroneously instead revert he uses update to rev 99 of that file, so would not be surprised about a warning about to "force" the action. This may not cause data loss, but other severe surprises some time later, as he may oversee, that his WC now is of rev 99.

> I do understand it's something users coming from Subversion do not expect
> but that's the way hg works.
It may be not a general understanding problem of hg, but just a beginners problem of understanding/assigning/finding NetBeans UI menus upon hg functionality, as it was for me after a longer time of not using NetBeans for hg.
Comment 3 Ondrej Vrabec 2014-08-03 18:24:52 UTC
(In reply to ulfzibis from comment #2)
> But it can be seen as a defect that Mercurial->Update on single file is
> enabled in GUI at all.
Disagree. The file belongs to a certain repository, the action affects that repository -> the action is available for the file. I wonder where would you display the action if your repository root lies one folder above the project? According to your suggestions, it would not be available for any node in the projects view or files view, so user would have to go to the Favorites view. Don't you think users will kill us for that?

> Imagine user has edited referring file and WC is on rev 100. Erroneously
> instead revert he uses update to rev 99 of that file, so would not be
> surprised about a warning about to "force" the action. This may not cause
> data loss, but other severe surprises some time later, as he may oversee,
> that his WC now is of rev 99.
So you run Update again and you're back on rev 100. BTW pay attention to what dialogs say. The title says "Update repository - repo name".
> It may be not a general understanding problem of hg, but just a beginners
> problem of understanding/assigning/finding NetBeans UI menus upon hg
> functionality, as it was for me after a longer time of not using NetBeans
> for hg.
Sure. And now you know how it works.

I will not disable the action on files or folders. Closing.
Comment 4 ulfzibis 2014-08-05 21:48:30 UTC
(In reply to Ondrej Vrabec from comment #3)
> I wonder where would you
> display the action if your repository root lies one folder above the
> project? According to your suggestions, it would not be available for any
> node in the projects view or files view, so user would have to go to the
> Favorites view. Don't you think users will kill us for that?

Agreed. Thanks for pointing on that.

> So you run Update again and you're back on rev 100.

... if user is aware of being in rev 99. That's what I wanted to point on. See also: Bug 245574.

> BTW pay attention to what dialogs say. The title says "Update repository - repo name".

This is a little misleading, because the working copy is updated, not the repository. So please allow me to suggest a little enhancement for the dialogue title:
"Update all from Repository: RepoPath/"
Because in most standard situations the last element in the path of the repo is same named as the concerned project which may be mixed:
- Use ':' instead '-'.
- Add a file separator at the end.
(Maybe you have another better idea) :-/
Comment 5 ulfzibis 2014-08-05 22:00:49 UTC
A litte better with U+2026 HORIZONTAL ELLIPSIS :

"Update all from Repository: …RepoPath/"

…and on Windows use "\" (java.io.File.separatorChar)