This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 251441 - On Aqua, sub-tabs in "Output" tab have vertically off-center text and close buttons
Summary: On Aqua, sub-tabs in "Output" tab have vertically off-center text and close b...
Status: NEW
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 8.0.2
Hardware: PC Mac OS X
: P4 normal with 1 vote (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-26 15:24 UTC by ebakke
Modified: 2018-04-22 19:12 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Current screenshot and mockup of proposed adjustment (42.95 KB, image/png)
2015-03-26 15:24 UTC, ebakke 		Details
Proposed patch (781 bytes, patch)
2016-10-26 01:40 UTC, ebakke 		Details | Diff
Screenshot before and after the proposed patch (30.06 KB, image/png)
2016-10-26 01:41 UTC, ebakke 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ebakke 2015-03-26 15:24:30 UTC 
Created attachment 152862 [details]
Current screenshot and mockup of proposed adjustment

On MacOS/Aqua, the text and close ("X") buttons of sub-tabs in the "Output" TopComponentm such as "Debugger Console" and "Run", are vertically off-center.

I suggest pushing the text down 1 pixel and the "X" buttons down 2 pixels in such components.

The attached image shows both the current appearance and a mockup of the new appearance as would result from the proposed adjustments.
Comment 1 ebakke 2016-10-26 01:40:06 UTC 
Created attachment 162640 [details]
Proposed patch

Proposed patch. Tested on MacOS 10.9.5 (see screenshot, which I will attach next).

Note that the methods setPressedCloseButtonIndex and setMouseOverCloseButtonIndex in CloseButtonTabbedPane are mutually recursive but are not actually called from any other location in the source. They can thus be removed, along with several related helper functions:

org.netbeans.core.windows.view.ui.CloseButtonTabbedPane
  .setPressedCloseButtonIndex
  .setMouseOverCloseButtonIndex
  .getCloseButtonBoundsAt
  .findTabAt
  .isWindowsVistaLaF
  .isMetalLaF
  .isGTKLaF
  .pressedCloseButtonIndex
  .mouseOverCloseButtonIndex
Comment 2 ebakke 2016-10-26 01:41:17 UTC 
Created attachment 162641 [details]
Screenshot before and after the proposed patch

Screenshot of the "Search Results" tabs before and after the proposed patch previously submitted.
Comment 3 ebakke 2018-04-22 19:12:45 UTC 
Created a JIRA issue for this: https://issues.apache.org/jira/browse/NETBEANS-712