This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 255062 - EditableDiffView sets "usedByCloneableEditor" property on its editor panes but does not clear them
Summary: EditableDiffView sets "usedByCloneableEditor" property on its editor panes bu...
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 8.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Miloslav Metelka
URL:
Keywords:
Depends on:
Blocks: 239360
  Show dependency tree
 
Reported: 2015-09-07 14:42 UTC by Miloslav Metelka
Modified: 2015-09-08 01:21 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2015-09-07 14:42:13 UTC 
The property is manually set at EditableDiffView:285 and EDV:294 but it's not cleared after closing the diff view (like e.g. in CloneableEditor.componentClosed()) so the two editor panes will not be removed from EditorRegistry and they leak through a reference from AnnotationBar.

I've added a code that traverses component hierarchy and clears the  "usedByCloneableEditor" properties but I'd like to ask Ondra V. to review the fix and possibly change it. Thanks in advance.
Comment 1 Miloslav Metelka 2015-09-07 14:44:04 UTC 
http://hg.netbeans.org/jet-main/rev/fa4dc69a4d0f
Comment 2 Quality Engineering 2015-09-08 01:21:17 UTC 
Integrated into 'main-silver', will be available in build *201509080002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/fa4dc69a4d0f
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #255062 - EditableDiffView sets "usedByCloneableEditor" property on its editor panes but does not clear them.