This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Following classes contain hardcoded colors and causing problems with different look and feels, especially dark ones: 1) org.netbeans.modules.editor.search.SearchBar: NOT_FOUND = Color.RED.darker(); 2) org.netbeans.editor.GlyphGutter: DEFAULT_GUTTER_LINE = new Color(184, 184, 184); 3) org.netbeans.modules.search.ui.AbstractSearchResultsPanel:180: contentPanel.setBorder(BorderFactory.createLineBorder(new Color(153, 153, 153))); 4) org.netbeans.modules.options.OptionsPanel#CategoryButton: background, foreground and borders are hardcoded, special colors provided for Nimbus they are also hardcoded. I would like to suggest: 1) Use LFCustoms.ERROR_FOREGROUND ("nb.errorForeground") 2, 3) Use LFCustoms.SCROLLPANE_BORDER_COLOR ("Nb.ScrollPane.Border.color") 4) Could introduce new UIManager keys or at least fallback to Tree|Table|List colors.
I would like to report more hardcoded colors: 1) org.netbeans.modules.form.layoutdesign.LayoutPainter: - line 976: Color gapBorderColor = new Color(200, 200, 200); - line 977: Color sawColor = new Color(208, 208, 208); 2) org.openide.awt.ToolbarWithOverflow: - line 142: overflowToolbar.setBorder(BorderFactory.createLineBorder(Color.LIGHT_GRAY, 1)); 3) org.netbeans.modules.diff.builtin.visualizer.editable.DiffSplitPaneDivider: - line 255: g.setColor(Color.LIGHT_GRAY); I would like to suggest using SCROLLPANE_BORDER_COLOR for all three cases: Use LFCustoms.SCROLLPANE_BORDER_COLOR ("Nb.ScrollPane.Border.color")
Added 'fix-in-82' in status whiteboard.
As @Revivius mentioned in https://github.com/Revivius/nb-darcula/issues/108, Following code also has hardcoded colour for javascript documentation window: http://hg.netbeans.org/main/file/294dca090459/javascript2.editor/src/org/netbeans/modules/javascript2/editor/doc/JsDocumentationPrinter.java#l141 Above code also should be fixed along with other hardcoded colour issues.
For reference https://github.com/Revivius/nb-darcula/issues/39
*fixed* http://hg.netbeans.org/core-main/rev/93615abab29f * use UIManager.getColor("controlShadow") instead of gray color * use UIManager.getColor("nb.errorForeground") instead of red color * introduce "nb.formdesigner.gap.border.color"/"nb.formdesigner.saw.color", but keep fallback to old colors for LaFs, which do not provide the colors I did not update org.netbeans.modules.options.OptionsPanel. To much to do there.
Integrated into 'main-silver', will be available in build *201607250002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/93615abab29f User: Benno Markiewicz <markiewb@netbeans.org> Log: #257675 - Hardcoded colors in SearchBar, GlyphGutter, AbstractSearchResultsPanel, ToolbarWithOverflow, LayoutPainter, DiffSplitPaneDivider * use UIManager.getColor("controlShadow") instead of gray color * use UIManager.getColor("nb.errorForeground") instead of red color * introduce "nb.formdesigner.gap.border.color"/"nb.formdesigner.saw.color", but keep fallback to old colors for LaFs, which do not provide the colors