This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 27655 - Deprecate Places.Nodes.packages (Was: Deal with PackageChildren in core)
Summary: Deprecate Places.Nodes.packages (Was: Deal with PackageChildren in core)
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords: API
Depends on:
Blocks: 27646
  Show dependency tree
 
Reported: 2002-09-27 16:22 UTC by David Strupl
Modified: 2008-12-22 21:50 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Strupl 2002-09-27 16:22:45 UTC 
Deprecation of org.openide.filesystems.FileObject
- String getPackageName(char) affects : 
   org.netbeans.core.PackageChildren.1.void run()
   org.netbeans.core.PackageChildren.Node[]
createNodes(Object)

Should we deprecate places - packages?
Comment 1 Peter Zavadsky 2002-09-27 17:14:06 UTC 
Places.Nodes.packages() should be deprecated. The method doesn't have
a sense in open API context. Moreover nobody uses the method in
current NB dev build.

It seems there should be considered if other Places methods (or
interfaces or even entire Places) could be deprecated too. Notion of
some "interesting" things in IDE sounds strange in open API.
Going to look at it.
Comment 2 Peter Zavadsky 2002-09-30 12:24:27 UTC 
Yarda, say something:
packages method should be deprecated in any way.
Question is if it should still return the PackageNode, which won't be
probably working correctly
or just return some empty node, so we could remove the PackageNode
completelly.
I vote for the second choice, remember it is not used now anyway.

------------------------------------------------------------

BTW I guess Places should be deprecated, but that's another issue.

Nodes are used almost in core only, also in some property editors(??)
in openide and scripting module, but that's just a "mirroring".
I didn't check at the use of folders, but it is probably the same.

Anyway that's not important. 
I guess the Places could be replaced by naming funcionality.
Depends how far the naming is implemented.
Comment 3 Peter Zavadsky 2002-10-01 12:54:29 UTC 
I'm going to deprecate the packages method and also move the Packages
and PackageChildren to objectbrowser.
Obejctbrowser needs to deal with it separately -> issue #27707.
Comment 4 Peter Zavadsky 2002-10-01 13:06:17 UTC 
Fixed in [trunk]

openide/../Places.java 1.33
core/../NbPlaces.java 1.60
        Packages.java - removed
        PackageChildren - removed
objectbrowser/../Packages.java 1.1 - added
                 PackageChildren 1.1 - added
                 ClassBrowserHierarchyTranslator.java 1.37
                 manifest.mf 1.40
Comment 5 Jaroslav Tulach 2002-10-02 09:31:13 UTC 
Cool and capabilities testing is there too. That means that if the
root filesystem for all drives does not have any of the common
capability (EXEC, COMPILE, DOC, DEBUG) then it will not be shown in
the list of packages. That is very good, but Radek please do not
forget to remove all the capabilities.