This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 27776 - Should convert package deps to core/javahelp module dep
Summary: Should convert package deps to core/javahelp module dep
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Jesse Glick
Keywords: API
Depends on:
Blocks: 19620 22839 25418
  Show dependency tree
Reported: 2002-10-03 15:04 UTC by Jesse Glick
Modified: 2008-12-23 08:35 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Proposed patch - compiles, but totally untested (2.64 KB, patch)
2002-10-24 16:56 UTC, Jesse Glick
Details | Diff
Proposed patch for 3.4.1 (2.72 KB, patch)
2002-11-29 13:56 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-10-03 15:04:35 UTC
A bit late, but I think Rochelle was right here -
older modules that declared a package dependency
on (e.g. apisupport, apparently TP?)
should have been automatically given a dep on
org.netbeans.modules.javahelp/1 in 3.4, to let
them continue to use the package.
org.netbeans.core.modules.NbInstaller permits this
kind of thing. Better late than never, right?
Comment 1 Jesse Glick 2002-10-23 22:29:43 UTC
Turns out someone cares (BT #4763333).
Comment 2 Jan Chalupa 2002-10-24 09:35:21 UTC
This is a showstopper for the S1S Application Server plugin. S1S
escalated it as a Q-build stopper for the 200210230100 Q-build as it
blocks their testing.

Please fix asap. In the QBE200210230100 branch, too. Thanks.
Comment 3 Jesse Glick 2002-10-24 14:21:47 UTC
It blocks their testing when there is a workaround which requires
about ten seconds of effort and which I documented in the BT report??

Whatever, I will fix as soon as I can.
Comment 4 Jesse Glick 2002-10-24 14:56:49 UTC
Have patch, untested.
Comment 5 Jan Chalupa 2002-10-24 15:52:31 UTC
The purpose of the testing is to verify that the S1S4u1 module still
works with the NB trunk. I understand this can be easily fixed by the
module owner for the next release of the module. However, QA shouldn't
be required to touch any of the module's files (including its manifest).

Thank you for working on it. Can the patch be made available?
Comment 6 Jesse Glick 2002-10-24 16:56:29 UTC
Created attachment 7761 [details]
Proposed patch - compiles, but totally untested
Comment 7 Jesse Glick 2002-10-24 18:21:25 UTC
Previously posted patch did not work; missing line it.remove(); before
break; line - need to remove package dep while adding
org.netbeans.modules.javahelp module dep.

Seems to be fixed now. Tried with an old apisupport.nbm (2.10.2,
designed for NB 3.3.x). Worked fine, after I fixed that JAR file to
include the required Manifest-Version: 1.0 in the manifest header.
Specifically tested an operation which accessed 1.54
Comment 8 Jan Chalupa 2002-10-25 16:15:04 UTC
Jesse, could you put the fix into the QBE200210230100 branch too? Thanks!
Comment 9 Jesse Glick 2002-10-26 18:11:07 UTC
Done; committed to QBE200210230100 branch (
Comment 10 Jan Chalupa 2002-10-29 14:24:55 UTC
Great, thanks.
Comment 11 Jesse Glick 2002-11-29 13:56:00 UTC
Created attachment 8109 [details]
Proposed patch for 3.4.1
Comment 12 Jesse Glick 2002-11-29 13:56:57 UTC
Yarda, Trung, or someone, could I get a quick review of the attached
patch? Thanks.
Comment 13 Jaroslav Tulach 2002-12-02 16:46:27 UTC
The 341 patch is no worse than the maintrunk one.
Comment 14 Jesse Glick 2002-12-02 18:44:43 UTC
In release341:

Checking in core/src/org/netbeans/core/modules/;
/cvs/core/src/org/netbeans/core/modules/,v  <--
new revision:; previous revision: 1.41
Comment 15 pzajac 2003-06-11 14:02:38 UTC
verified fixed
Comment 16 Quality Engineering 2003-07-01 16:20:58 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.