This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 30277 - Context menu on Filesystems node is slow...
Summary: Context menu on Filesystems node is slow...
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@platform
URL:
Keywords: PERFORMANCE, UI
Depends on:
Blocks: 26581
  Show dependency tree
 
Reported: 2003-01-22 16:51 UTC by Tomas Pavek
Modified: 2008-12-22 15:58 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Pavek 2003-01-22 16:51:17 UTC
... in the first use. It takes around 600ms on my
machine (P3 733, 512 MB RAM, W2K).

Running in profiler, it looks like over 70% of
time is spent in ToolsAction.Popup.run(). Is it
necessary to have ToolsAction on FS node? It loads
really large number of classes from different places.
Comment 1 Tomas Pavek 2003-01-28 16:18:02 UTC
Implementing warm-up in issue 27769 helped to reduce the time to cca
450ms (build dev 20030128).
Comment 2 _ ttran 2003-01-29 15:31:13 UTC
dpavlica: what do you think about removing Tools submenu from
Filesystems node's context menu as Tomas suggested.  It doesn't make
much sense to me either.
Comment 3 dpavlica 2003-01-29 16:29:20 UTC
That text "Empty" in the submenu looks really strange and isn't logic. 
So...Let's remove Tools item from Filesystems node's context menu...
Comment 4 Tomas Pavek 2003-01-29 16:50:46 UTC
It's a bit more complicated. The "Tools" menu does not appear in the
context menu on FS node now (it appeared - empty - due to another
bug). But the ToolsAction *is* on the FS node, it is not displayed as
there is no individual subaction enabled for this node. Evaluating all
the actions during context menu invocation is the performance problem.
Removing the ToolsAction from the node would eliminate it, but what if
some tools action for FS node appears in the future? Or some external
module provides some already now? So just removing it is not that
easy. The second way is to cancel the evaluating of the actions and
show "Tools" menu always when ToolsAction is present, but then we
would get again the "Tools" > "Empty" menu...

Is there a solution for this?
Comment 5 dpavlica 2003-02-03 16:30:24 UTC
I see...Then we got back and we are marking time.
Empty text in sub menu is really strange and I don't vote 
for it. 

So does exist another solution ? Unless improvement of 
implementation ;) I am thinking about UI hack way. 

It means: Showing Context menu with disabled and italic 
text "Resolving..." instead Tools text first. Then display 
right result (Enabled or Disabled Menu Item "Tools") on 
that place after evaluating of the actions.

But it's hack and maybe worse then Empty text, maybe not ;)
Comment 6 dpavlica 2003-02-07 15:36:32 UTC
Some notes after discussion with performance team and HIE 
team:
It's reasonable to taking away Tools from Filesystems from 
HIE point of view.
It isn't not correct compatible change on the other hand 
(says on nbdev) and Proposed solution is here:

http://www.netbeans.org/servlets/ReadMsg?
msgId=462005&listName=nbdev

1a. showing the action with empty submenu, if there is no 
enabled action: Tools->Empty
1b. doing 1a only for the first time, as soon as 
ToolsActions are loaded, one can hide the action quickly
2. warming up all ToolsActions, as it is something every 
user will need one day.
3. Replacing the submenu with a dialog to select the right 
action. Something that happened to New... action. 

I have not agreed with 1a) 1b) yet and 3) isn't ok because 
user would like to use Tools action quick without another 
dialog.
So it looks that 2) could help, but I don't know if so 
much...

Comment 7 Marian Mirilovic 2004-04-09 17:21:56 UTC
Filesystems node is no more present in promo-D