This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 36512 - [2003-11-15] Prepare all TopComponents in VCS modules for upcoming winsys2 merge
Summary: [2003-11-15] Prepare all TopComponents in VCS modules for upcoming winsys2 merge
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC All
: P2 blocker (vote)
Assignee: issues@obsolete
URL:
Keywords:
Depends on: 36543
Blocks: 36118 37621
  Show dependency tree
 
Reported: 2003-10-09 16:48 UTC by Tomas Pavek
Modified: 2003-12-11 14:27 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Pavek 2003-10-09 16:48:52 UTC
Need to go through all the TopComponents in VCS
modules to see how they work with the new window
system. 

1) get a list of all TopComponents & modes

2) for each describe how they should behave in the
new winsys and what is needed to do.

The main problem will be with the floating
TopComponents that are no more supported. They
would be docked into the Editor (Documents) area
by default. We need to decide if they
- should go to Documents mode (default)
- or to Output mode
- or to some special mode
- or be non-modal dialogs (to remain floating).

See also issue 36119 which provides some
suggestions. Issue 36489 lists some problems
discovered so far (VCS outputs are mentioned).
General guidelines are summarized in issue 36487.
Comment 1 Tomas Pavek 2003-10-09 17:27:04 UTC
See also issue 29836.
Comment 2 Tomas Pavek 2003-10-23 16:59:37 UTC
For the winsys2 merge to trunk we will ensure just that:
- Versioning Explorer will appear in explorer mode and will be renamed
  to 'VCS Filesystems'
- VCS Groups will appear in explorer mode too
- both will be available in Window | Versioning menu for showing
  (versioning explorer must be enabled even when there is no versioned
   file/folder selected)
- the other windows (mainly various VCS output window will appear in
  the editor area (like other documents).

We already have some patches for the above, they will be integrated
just after the merge (no need to branch vcs modules now). The patches
will be tested and confirmed working before that by QA.

We will do complete categorization of windows after the merge and plan
for better integration with the new winsys (including redesign of some
components to fit into the output area, fine-tuning of tab names,
etc). Separate issue will be filed for this.
Comment 3 Tomas Pavek 2003-11-05 09:37:14 UTC
A snippet from the current spec describing names and icons of document
 windows (from http://ui.netbeans.org/docs/ui/ws/ws_spec.html#3.3):

----------------
Some of the objects may have more than one associated document window,
for example a form object can be viewed by source editor, form editor,
and also by cvs viewers (annotate, diff, ...). One of the multiple
document windows of an object is always a base document window of the
object. All other document windows of that object are an extending
document windows. For instance, in case of form object, the source
editor is the base document window, and form editor, cvs viewers are
the extending document windows.

* Name of extending document window - name of the extending document
window also corresponds to a name of object it displays, e.g.
"ColorPicker". However, the name of the window contains also a suffix
identifying the type of editor/viewer contained in the document
window. The name pattern is following: "<object name> [<editor/viewer
type>]". An example is "ColorPicker [Form]", "ColorPicker [VCS
Annotate]", "ColorPicker [VCS Log]".

* Icon of extending document window - icon of extending document
window doesn't represent displayed object, but the editor or viewer
type contained in the extending document window. For example, a form
editor would have a special icon, all VCS viewers would have a special
icon (not a special icon for each VCS command, but the same icon for
all VCS type viewers).
Comment 4 Tomas Pavek 2003-11-05 09:48:25 UTC
Removing ws2merge keyword; this cannot be done before the merge - will
be prepared and done just after the merge (so we need not branch).
Comment 5 Tomas Pavek 2003-11-18 10:12:49 UTC
Done.

/cvs/diff/src/org/netbeans/modules/diff/builtin/DefaultDiff.java
new revision: 1.11; previous revision: 1.10
/cvs/diff/src/org/netbeans/modules/diff/builtin/visualizer/DiffComponent.java
new revision: 1.13; previous revision: 1.12
/cvs/diff/src/org/netbeans/modules/merge/builtin/visualizer/MergeDialogComponent.java
new revision: 1.20; previous revision: 1.19

/cvs/javacvs/src/org/netbeans/modules/cvsclient/commands/DefaultInfoPanel.java
new revision: 1.18; previous revision: 1.17

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsAnnotate.java
new revision: 1.7; previous revision: 1.6
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/Bundle.properties
new revision: 1.3; previous revision: 1.2
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/OutputVisualizer.java
new revision: 1.4; previous revision: 1.3
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/annotate/CvsAnnotateVisualizer.java
new revision: 1.3; previous revision: 1.2

/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/Bundle.properties
new revision: 1.25; previous revision: 1.24
/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandOutputVisualizer.java
new revision: 1.23; previous revision: 1.22
/cvs/vcscore/src/org/netbeans/modules/vcscore/grouping/VcsGroupMenuAction.java
new revision: 1.15; previous revision: 1.14
/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/impl/VersioningExplorer.java
new revision: 1.12; previous revision: 1.11