This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 36923 - Possibility to fix broken import
Summary: Possibility to fix broken import
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: mslama
URL:
Keywords:
Depends on:
Blocks: 36122
  Show dependency tree
 
Reported: 2003-10-30 07:47 UTC by Jaroslav Tulach
Modified: 2008-12-22 16:00 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2003-10-30 07:47:24 UTC 
The support for importing layout of components
from old window system is know not to be perfect
and actually can hardly ever be perfect due to
differences between winsys1 and winsys2. 

That is why the reviewers request, in order to
keep old modules functional, ability for the user
to fix and modify the layout of all imported
components.

As an example Tim's navigator module was used
(needs to be along editor, but is actually treated
as editor in winsys2, which makes it unusable and
user cannot do anything about it). This is however
minimal test, all other modules can be broken in
similar way and there needs to be a way to get
from such situation.
Comment 1 Peter Zavadsky 2003-10-31 10:11:55 UTC 
Oh here is the current solution we agreed I guess, imported
TopComponents are opened in default editor mode, unless they were
defined in mode, which was already loaded from new version of XML.

Then such TopComponent, would be possible to move (via DnD) to any
mode, even crossing the edito/view border which is prohibited otherwise.

The first part is implemented, and the second one is up to me.
Comment 2 Peter Zavadsky 2003-11-03 09:58:33 UTC 
The second part was devided, the preparation part is commited in
[winsys_29836] branch

core/windows/../Constants.java 1.1.2.20
               /ModeImpl.java 1.1.2.50
               /WindowManagerImpl.java 1.1.2.110
               /view/EditorView.java 1.1.2.23
                    /dnd/TopComponentDroppable.java 1.1.29
                        /WindowDnDManager.java 1.1.2.35
                    /ui/AbstractModeContainer.java 1.1.2.15
                       /DefaultSeparateContainer.java 1.1.2.39
                       /DefaultSplitContainer.java 1.1.2.43
                       /NestedSplitPane.java 1.1.2.20

Assignign to Marek, to finish it by adding the needed client property
to imported TopComponents.
Comment 3 mslama 2003-11-03 12:13:30 UTC 
Client property "TopComponentAllowDockAnywhere" of TopComponent is set
when TC is imported when PersistenceManager creates TC instance.

core/windows/src/org/netbeans/core/windows/persistence/PersistenceManager.java
r.1.1.2.32
core/windows/src/org/netbeans/core/windows/persistence/convert/Attic/ImportManager.java
r.1.1.2.7
Comment 4 Lukas Hasik 2004-02-26 14:39:31 UTC 
Yarda, could verify, please ? thanks advance.
Comment 5 Jaroslav Tulach 2004-02-26 16:31:19 UTC 
Import can be fixed by dnd.