This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 41176 - ArchiveURLMapper should not return URL for JARs mounted in Repository
Summary: ArchiveURLMapper should not return URL for JARs mounted in Repository
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: rmatous
URL:
Keywords: TEST
Depends on: 41506
Blocks:
  Show dependency tree
 
Reported: 2004-03-21 21:54 UTC by Jesse Glick
Modified: 2008-12-23 00:37 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-03-21 21:54:06 UTC
testJarMapping:	correct URL -> FO for root
expected:<[AbstractFileObject@12cc95d[jar:file:/space/src/nb_all/openide/test/work/user/org.openide.filesystems.URLMapperTest/testJarMapping/test.jar!/]]>
but
was:<[AbstractFileObject@12cc95d[jar:file:/space/src/nb_all/openide/test/work/user/org.openide.filesystems.URLMapperTest/testJarMapping/test.jar!/],
AbstractFileObject@157fb52[jar:file:/space/src/nb_all/openide/test/work/user/org.openide.filesystems.URLMapperTest/testJarMapping/test.jar!/]]>

Presumably URLMapper's default impl returns the
JarFileSystem file once, and then ArchiveURLMapper
returns it again. One or the other should be
removed. (URLMapper could also remove duplicates
before returning its results, though that would be
an inefficient way to solve this bug.)
Comment 1 David Konecny 2004-03-22 09:38:25 UTC
I already have hotfix for the test because I'm adding these tests to
commit validation suite.

ArchiveURLMapper could check whether the jar is in Repository and if
yes does do provide URL because it will be returned by default URLMapper.
Comment 2 David Konecny 2004-03-24 14:02:35 UTC
Test is fixed now. Changing summary to match remaining problem.

Btw. Tomas, I changes impl of ArchiveURLMapper to match
DefaultURLMapper (i.e. jar file name is not encoded now). Otherwise it
was pretty confusing to get for the one file two different URLs. 
Comment 3 rmatous 2004-03-31 12:06:38 UTC
If  issue, described in #41506, is accepted then there is no reason to
do any additional checks here which could cause useless performance
penalty.  



Comment 4 Jesse Glick 2004-04-02 22:51:27 UTC
Issue #41606 would help only if URLMapper's static methods did not
merge together results from all impls.
Comment 5 rmatous 2004-06-22 16:06:46 UTC
OK from my point of view.
Comment 6 Marian Mirilovic 2005-12-20 15:46:51 UTC
This issue was solved long time ago. Because nobody has reopened it neither
added comments, we are verifying/closing it now. 
If you are still able to reproduce the problem, please reopen. Thanks in advance.