This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47649 - Copy/Paste should not create *_1 files
Summary: Copy/Paste should not create *_1 files
Status: NEW
Alias: None
Product: java
Classification: Unclassified
Component: Source (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker with 1 vote (vote)
Assignee: Svata Dedic
: 47705 (view as bug list)
Depends on:
Reported: 2004-08-22 12:40 UTC by _ tboudreau
Modified: 2014-01-27 10:55 UTC (History)
2 users (show)

See Also:
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2004-08-22 12:40:49 UTC
Rename class X to Y.

Inside it, there will still be things like

NbBundle.getMessage (X.class, "foo");

shouldn't they also be changed?
Comment 1 Martin Matula 2004-08-23 08:39:54 UTC
Of course it should and it normally does. Can you reprodude this?
Couldn't this be related to the OOME you filed as issue 47651?
Comment 2 Martin Matula 2004-08-23 14:02:30 UTC
*** Issue 47705 has been marked as a duplicate of this issue. ***
Comment 3 Martin Matula 2004-08-23 14:03:23 UTC
Strange - I am really not able to reproduce it. Could you please
provide a sample code?
Comment 4 _ tboudreau 2004-08-23 14:12:04 UTC
My fault.  It is not really that it doesn't work - it's that when a
file is copied and pasted, its name is changed to something like
Foo_1.  That operation does not run refactoring on the file.  So then
when you try to rename it to something sensible, all of the references
to Foo in the class are skipped because they don't say Foo_1.

So, it's invalid as problem in refactoring - but probably should be
fixed somehow in how a pasted file of the same name is handled.
Comment 5 Jesse Glick 2004-08-31 19:34:15 UTC
Issue #47705 sounds like something different, no?
Comment 6 _ tboudreau 2004-08-31 23:25:25 UTC
Can't imagine what Issue #47705 has to do with this.
Comment 7 Martin Matula 2004-09-01 15:03:39 UTC
Both issues are about replacing references to a class from itself in
".class" expressions. Or am I missing something?
Comment 8 _ tboudreau 2004-09-01 17:30:35 UTC
Possibly:  That when you copy and paste a file into the same package, it is renamed, but 
no refactoring runs, so you have SomeClass_1 with references to SomeClass in it.  When 
you then rename SomeClass_1 to something else, refactoring works fine, but it doesn't 
figure out that references to SomeClass really were supposed to be references to 
SomeClass_1, which would be touched by the refactoring.

IMO two bugs here:
1. The handling of pasting a file when a file with the same name exists in the folder is 
retarded - nobody actually means to create SomeClass_1, so this functionality is totally 
useless - it should pop up a dialog and ask for a name (IDEA handles this nicely this way).  
Otherwise we're just making extra work for the user to rename it later.

2. Either way, that action is going to have to trigger the Rename refactoring to run, not 
just rename the file and its class declaration.  Otherwise trying to rename it to something 
meaningful is broken.

For 1., yes there will have to be some handling of the situation that 10 files are copied and 
pasted from a folder to the same folder, but it's not an excuse not to fix it, and the most 
common case is 1 file.  We could even leave it broken for multiple files and it would still be 
an improvement.
Comment 9 Jan Becicka 2004-10-14 09:15:30 UTC
Tim, your last comments is not a bug, but enhancement for java module.
Refactoring module does not create those _1 files.

> 2. Either way, that action is going to have to trigger the Rename
refactoring to run, not 
just rename the file and its class declaration.  Otherwise trying to
rename it to something 
meaningful is broken.

trigger the rename refactoring? Why? New class SomeClass_1 was
created, but no class was renamed. No rename refactoring is needed.

Comment 10 Jesse Glick 2004-10-14 18:45:53 UTC
Note that creation of *_1 files in general is handled by Datasystems.
The java module just inherits this behavior.
Comment 11 Rastislav Komara 2009-02-03 10:55:30 UTC
Comment 12 Jan Lahoda 2010-05-11 13:46:40 UTC
Resetting assignee to default for all bugs reported against product java and assigned to moonko.