This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Please tweak the appearance of the document tabs and editor toolbar in win classic L&F according to the UI spec. The difference between the implementation and specification includes (pointed out in the attached image): 1a) Implementation: Heavy border is between the editor toolbar and window splitter. Specification: Soft etched border is between the editor toolbar and window splitter. 1b) Implementation: 12px spacing is between the editor toolbar combo box and left border. Specification: 2px spacing is between the editor toolbar combo box and left border. 2) Implementation: No white line is in the border between the non- active editor tab and editor toolbar. Specification: A white line is a bottom line in the border between the non-active editor tab and editor toolbar. 3) Implementation: No border is between the empty tabbed pane area and editor toolbar. Specification: A soft border is between the empty tabbed pane area and editor toolbar. 4) Implementation: (163, 163, 163) is the background color of the empty tabbed pane area. Specification: (180, 177, 170) is the background color of the empty tabbed pane area. 5) Implementation: A lowered bevel border is between the editor toolbar and right window splitter. Specification: An etched border is between the editor toolbar right window splitter. 6) Implementation: 2px spacing is between the editor combo box and first toolbar separator. Specification: 8px spacing is between the editor combo box and first toolbar separator. Probably not all the differences mentioned here should be fixed in core module, so reassign where appropriate, please.
Created attachment 17211 [details] Document tab bugs in win classic L&F.
reassigning
re 4. Could it be possible to use the swing contants for colors where applicable? I'm having problems mapping the RGB value to a eg. "Control.shadow"? re 1.b + 6 - editor module issues. re 1a+2+3+5 - I've discussed this with Dusan multiple times already and didn't find a solution. Quite hard to fix, since the border painting depends on the content of TabDisplayer, the content area plus the editor's topcomponent toolbar component. I've managed to fix 1a for multiviews where the toolbar has fixed height. (5 could be fixed in the same way) however in regular TC the toolbar can appear and disappear depending on user settings and no assumption can be made regarding the toolbars height.
MArtin, can you please take a look at issue 1.b + 6 in the list. I believe these are editor related. Please reassign back to me then.
Yes Milos, you are right - see editor issue #37665
Re: 4. Could it be possible to use the swing contants for colors where applicable? I'm having problems mapping the RGB value to a eg. "Control.shadow"? I am not sure, Dusan should know the answer. The color the spec defines is already used and implemented as a background color of window tabs and document tabs, too. Re: 1a+2+3+5 - I've discussed this with Dusan multiple times already and didn't find a solution. Quite hard to fix, since the border painting depends on the content of TabDisplayer, the content area plus the editor's topcomponent toolbar component. I think that in case of 1a and 5, the editor should simply paint the border. In case of 2 and 3, you paint it well in Metal L&F, why is it so different in win classic?
>I think that in case of 1a and 5, the editor should simply paint the >border. Cannot. Constraint given by current implementation. >In case of 2 and 3, you paint it well in Metal L&F, why is it so >different in win classic? I investigate that.
reassigning to dafe, who has windows machine and can fix it faster.
Created attachment 18015 [details] Bugfix for points 2 and 3
dafe pls review the bugfix
Code looks OK, I believe you that visually it's OK too so please go on.
fixed in org.netbeans.swing.tabcontrol.plaf.WinClassicEditorTabDisplayerUI and org.netbeans.swing.tabcontrol.plaf.WinClassicEditorTabCellRenderer
hardly fixed, as there are more issues described in the bug than the ones fixed.
Correct, not all issues are solved, but most of them belongs to editor or is not implementable: issue 4) Stan should check this and add to its fix if not fixed already issues 1a) 5) Not fixable without rewrite of whole border management. Sorry but wontfix for me, we can talk about it offline. issues 1b) 6) belongs to editor. So I suggest Stan to check issue 4, fix if possible and pass this issue to editor guys to work on issues 1b) and 6).
Please, do not reassign this issue to editor. Items 1b and 6 are already tracked and fixed - for more details - issue #37665
OK, good. Didn't I tell you Milos that there is almost nothing left? :-)
Created attachment 18027 [details] Bugfix for part #4
- part #4: found a symbolic color for (180, 177, 170). dafe pls review.
Sounds OK, should work.
fixed part #4, the rest of the problems is either unfixable or being tracked elsewhere (see comments above).
Verified in NetBeans 4.2 Build 200507191800, JDK 1.6.0-ea