This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 48779 - + is used in Keyboard Shortcuts dialog instead of -
Summary: + is used in Keyboard Shortcuts dialog instead of -
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Dialogs&Wizards (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: UI
Depends on:
Blocks: 58412
  Show dependency tree
 
Reported: 2004-09-09 14:54 UTC by Patrick Keegan
Modified: 2012-04-26 07:37 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
a proposed patch (2.04 KB, patch)
2004-09-09 18:25 UTC, Jiri Rechtacek 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Keegan 2004-09-09 14:54:52 UTC 
The Sun convention for expressing keyboard
shortcuts is to use hyphens (-) between the keys,
not plus signs. E.g. Ctrl+K should be Ctrl-K
Comment 1 Marian Mirilovic 2004-09-09 15:03:44 UTC 
Kayboard Shortcuts dialog ...
Comment 2 Jiri Rechtacek 2004-09-09 18:09:02 UTC 
Note: see javadoc of java.awt.event.KeyEvent
/**
* Returns a String describing the modifier key(s), such as "Shift",
* or "Ctrl+Shift".  These strings can be localized by changing the 
* awt.properties file.
*
* @return string a text description of the combination of modifier
*                keys that were held down during the event
*/
public static String getKeyModifiersText(int modifiers) {

Should we do find&replace in returned string from this jdk's method?
Comment 3 Jiri Rechtacek 2004-09-09 18:25:28 UTC 
Created attachment 17533 [details]
a proposed patch
Comment 4 Jiri Rechtacek 2004-09-09 18:27:09 UTC 
The attached patch contains code which Search&Replace all occurrences
of '+' in returned values. No problem to integrate it.
Comment 5 Patrick Keegan 2004-09-09 18:29:11 UTC 
Interesting, Jirka. Thanks for the info. Does the hack you propose
have any performance implications or other dangers?

Jeff, should we file a bug against AWT?

Jirka, please don't integrate the patch yet.
Comment 6 Jiri Rechtacek 2004-09-10 08:54:32 UTC 
Ad performance: I don't afraid of any performance regression if the
patch will integrated. The set of shortcuts with some modifiers is
limited, moreover the strings are short and not often recalculated.
Comment 7 Jiri Rechtacek 2004-10-22 09:39:19 UTC 
No progress here. I change to PATCH type, I'm ready to integrate if
needed.
Comment 8 Patrick Keegan 2004-10-22 12:46:11 UTC 
I'm switching this to promo E because I'm uncomfortable making a UI
change so long after UI freeze, especially when it's a hack of
something that really should be fixed in the JDK.
Comment 9 Quality Engineering 2008-12-23 14:32:41 UTC 
This issue had *1 votes* before move to platform component
Comment 10 Stanislav Aubrecht 2012-04-26 07:37:36 UTC 
Native applications on MS Windows use "+" chars in keyboard shortcuts, closing.