This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55257 - Background color of code folds and glyph gutter add visual noise
Summary: Background color of code folds and glyph gutter add visual noise
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Roskanin
: 54747 63080 (view as bug list)
Depends on:
Reported: 2005-02-20 06:55 UTC by _ tboudreau
Modified: 2007-11-05 13:42 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2005-02-20 06:55:57 UTC
For whatever historical reason, there are two bars of different 
shades of gray on the right side of the editor - the glyph gutter 
and the code fold bar.

Aesthetically, the IDE's look is much cleaner if I manually set the 
background to white for both of these, and set a light blue or 
red/orange color for the code fold lines.  

Seriously, I recently did a demo for some folks, one of whom 
said "This is the nicest looking Swing application I've ever seen!".  
I can't prove it, but I'm not sure they would have said that if it 
had been the defaults.

I can imagine it might be important to differentiate the glyph 
gutter - it might help to have a, say, very pale vertical line 
demarking it.  But one can argue that the code folding lines are 
prevalent enough to make it clear where the gutter is.

Anyway, please consider doing this - it would make NetBeans 
much more nice looking in a subtle way, and the change is trivial 
to make.
Comment 1 Martin Roskanin 2005-02-21 09:04:43 UTC
OTOH, please look at the issues:
-issue #54747
-issue #40789

Perhaps, it would be good idea to add a demarkation line, although
there were some objections from Gabo in the past.

Ruda, could you please resolve this problem? Thanks.

Setting preliminary TM to 4.1
Comment 2 _ tboudreau 2005-02-21 09:22:37 UTC
I read the issues;  I think this is solvable fairly simply:  What information are we trying to 

The demarcation of the glyph gutter is important, because clicking will do something 
different there.   Two ways to solve that:

1.  A thin, low contrast vertical line that indicates it - the whole thing doesn't need a 
different background color
2. (preferred) Implement issue 22722 - use the mouse cursor to indicate when what 
clicking will do has changed.

For clicking over the glyph gutter, the simplest solution is to treat it as a click in column 0 
of the editor - at the worst you'd need to forward mouse events - if the user is not clicking 
on one of the [+] boxes in the glyph gutter, presumably she is trying to send the cursor 
somewhere (if you wanted to be super clever you could send clicks closer to the left to the 
gutter, but issue 22722 would solve that).

Anyway, the point is for clicking to do the "right" thing, and to indicate what a click will do 
in a given place, if it will *not* do what clicking anywhere in a text control will do.  We 
don't need big bands of color to solve that.
Comment 3 jrojcek 2005-02-22 08:35:33 UTC
I also think two color stripes are too much. The glyph gutter is probably okay (for 
breakpoints, etc.), but its color should change as it doesn't fit well in XP L&F, IMO. For the 
code folds, I agree with Tim, the background color should go away and we should think 
about the cursor change and do the right thing when the use click into the code folds 

Reassigning to Ruda.
Comment 4 _ tboudreau 2005-02-22 10:00:43 UTC
Glyph gutter looks pretty painful on mac os as well, FWIW - if anybody needs some help 
doing something mac-specific there, let me know.
Comment 5 Miloslav Metelka 2005-03-14 15:02:34 UTC
Rudo, any opinion regarding this for 4.1? Time is running out..
Comment 6 Rudolf Bock 2005-03-17 17:49:40 UTC
The light-grey background color for the glyph gutter is much more better than white background, 
because the user can see clearly the beginning of the line and at the same time, the gutter not 
extending visually the Editor work space.
A thin vertical line will be more disturbing than the current state.
I thing the current state is the best solution for this.
Comment 7 jrojcek 2005-03-21 17:04:56 UTC
Reopening after discussion with Ruda. We agreed that the fix for 40789 (introducing background color) 
improved the problem of clicking at the beginning of the line, but  hasn't in fact solved the issue as the 
user has to precisely point mouse cursor at a very tiny place between the folding background color and 
beginning of the text. Thus the background folding color is unnecessary and there should be a different 
solution for the original problem. Ruda will come up with the details. Thanks.
Comment 8 Martin Roskanin 2005-03-22 08:19:47 UTC
*** Issue 54747 has been marked as a duplicate of this issue. ***
Comment 9 Rudolf Bock 2005-04-05 14:35:43 UTC
I prepared a new spec. for this theme 
Comment 10 _ tboudreau 2005-04-06 03:48:28 UTC
Given that this makes a significant visual improvement, and it's just changing a couple color constants, 
any chance of doing it for 4.1?
Comment 11 _ tboudreau 2005-07-07 14:05:27 UTC
Raising priority since this is a simple thing to fix and it really does make NetBeans look unnecessarily 
ugly.  Simply setting the backgrounds of these components to Inherit (null) by default would be an 
improvement; fancier stuff can come later.  Currently whenever I demo NetBeans in public, I set this 
manually beforehand.  Since we didn't get this fixed for 4.1, could we do it soon?  Prosim pekne?
Comment 12 Roman Strobl 2005-08-15 13:32:48 UTC
Target milestone is obsolete, please re-evaluate. Thanks.
Comment 13 Martin Roskanin 2005-08-22 09:03:44 UTC
We will fix it soon in accordance with Ruda's ui spec.
Comment 14 Martin Roskanin 2005-08-22 15:17:19 UTC
fixed in [maintrunk]

Checking in libsrc/org/netbeans/editor/;
/cvs/editor/libsrc/org/netbeans/editor/,v  <--
new revision: 1.13; previous revision: 1.12
Checking in libsrc/org/netbeans/editor/;
/cvs/editor/libsrc/org/netbeans/editor/,v  <--
new revision: 1.25; previous revision: 1.24
Checking in libsrc/org/netbeans/editor/;
/cvs/editor/libsrc/org/netbeans/editor/,v  <--
new revision: 1.47; previous revision: 1.46
Checking in libsrc/org/netbeans/editor/;
/cvs/editor/libsrc/org/netbeans/editor/,v  <--
new revision: 1.59; previous revision: 1.58
Checking in libsrc/org/netbeans/editor/resources/glyphbutton.gif;
/cvs/editor/libsrc/org/netbeans/editor/resources/glyphbutton.gif,v  <-- 
new revision: 1.2; previous revision: 1.1
Checking in src/org/netbeans/modules/editor/;
/cvs/editor/src/org/netbeans/modules/editor/,v  <--
new revision: 1.9; previous revision: 1.8

Comment 15 Martin Roskanin 2005-08-22 15:58:20 UTC
for annotation support improvements mentioned at ui spec I have entered new
issue #55257
Comment 16 Martin Roskanin 2005-08-25 10:19:39 UTC
after new options dialog integration, the problem appeared again.
Default settings colors should be adjusted in new options dialog settings...
Comment 17 Martin Roskanin 2005-08-25 14:29:35 UTC
fixed in [maintrunk]

/cvs/editor/libsrc/org/netbeans/editor/,v  <--
new revision: 1.49; previous revision: 1.48
Checking in
 <--  NetBeans-editor.xml
new revision: 1.3; previous revision: 1.2
Comment 18 Martin Roskanin 2005-08-26 08:30:43 UTC
*** Issue 63080 has been marked as a duplicate of this issue. ***