This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Implement the layout of files described at http://openide.netbeans.org/proposals/arch/modularize.html Make independent part of module system part of boot.jar, separate the startup code and rest of modulesystem from core.jar and make the rest of core.jar real module.
Created attachment 21844 [details] Moving the module system to boot.jar (had to remove ManifestSection from the list)
BTW your style of expressing source moves is pretty confusing. Would be much clearer what you are doing if you prepared source patches to look like what the final state would be, *plus* attaching separate temporary files that do the moves themselves. What e.g. core/bootstrap/build.xml will be doing *after* you integrate is very difficult to understand from the patch. ProxyClassLoader and JarClassLoader are already in bootstrap (in a different package); no need to move them!
Re. confusing - if I was sure nobody modifies the sources, in trunk meanwhile, I could move the sources physically, but I was not a week ago. I can however do it on the branch. The branch is now rooted at BLD200505020835 and can be checked out by cvs upd -r move_58258 nbbuild core
Created attachment 21957 [details] Additional changes in openide to make the branch work at least a bit
For an unknown reason I trigger the dependency check more than once. At first all modules are updated to not depend on core, then they are updated once more for: [exec] Log: 16 msg: Warning - had to add recursive class loader dependencies for module org.openide.windows on [org.openide.dialogs]; see http://www.netbeans.org/download/dev/javadoc/OpenAPIs/org/openide/doc-files/upgrade.html#3.5i-indirect-dep-cp and once more and once more. Jesse, if you know how to prevent that, please suggest what to do.
...because org.openide.windows does not depend on the right version of openide, as I have mentioned before: http://www.netbeans.org/download/dev/javadoc/OpenAPIs/org/openide/doc-files/upgrade.html#3.5i-indirect-dep-cp We have to remove that compatibility check now I guess. Only applies to modules written against 3.4 or earlier so I doubt we care about compatibility any more.
I have also branched openide and updated to latest daily build BLD200505031800 Use: cvs upd -r move_58258 nbbuild core openide
Created attachment 22008 [details] Changes in other modules (mostly xtest) to let everything compile
Current files layout: # these jar files will be on classpath platform5/lib/boot.jar platform5/lib/nbexec.cmd platform5/lib/nbexec.exe platform5/lib/org-openide-modules.jar platform5/lib/org-openide-util.jar # these jars will be on our dynamic path platform5/core/core.jar platform5/core/org-netbeans-swing-plaf.jar platform5/core/org-openide-filesystems.jar platform5/core/updater.jar # the rest are real modules platform5/modules/ext/jh-2.0_02.jar platform5/modules/org-netbeans-core-execution.jar platform5/modules/org-netbeans-core-multiview.jar platform5/modules/org-netbeans-core-output2.jar platform5/modules/org-netbeans-core-ui.jar platform5/modules/org-netbeans-core-windows.jar platform5/modules/org-netbeans-core.jar platform5/modules/org-netbeans-modules-autoupdate.jar platform5/modules/org-netbeans-modules-javahelp.jar platform5/modules/org-netbeans-modules-masterfs.jar platform5/modules/org-netbeans-modules-queries.jar platform5/modules/org-netbeans-modules-settings.jar platform5/modules/org-netbeans-swing-tabcontrol.jar platform5/modules/org-openide-actions.jar platform5/modules/org-openide-awt.jar platform5/modules/org-openide-compat.jar platform5/modules/org-openide-dialogs.jar platform5/modules/org-openide-execution.jar platform5/modules/org-openide-explorer.jar platform5/modules/org-openide-io.jar platform5/modules/org-openide-loaders.jar platform5/modules/org-openide-nodes.jar platform5/modules/org-openide-options.jar platform5/modules/org-openide-text.jar platform5/modules/org-openide-util-enum.jar platform5/modules/org-openide-windows.jar
The initial review will be on Wednesday May 18, 2005. The assigned reviewer is going to be Radim Kubacki, other voting reviewers include Adam, Jesse and Jiri. http://openide.netbeans.org/proposals/arch/modularize.html I'd like the inception to produce "checklist of things" that need to be done before merge. If you know about something which is not correct, then please reply to my announcement on nbdev@ even sooner than next Wednesday. Especially of my interest is whether you agree with the proposed move of the classes and introduction of core/modules. I'd like to start to work on that soon, and it would be pain to revert that.
Wed May 18 when?
Merged with trunk BLD200505101800 and added xtest. Use: cvs upd -r move_58258 nbbuild core openide xtest
Created attachment 22105 [details] Updated to BLD200505111800 - use: cvs co -r BLD200505111800 openide core nbbuild xtest + apply the patch
Created attachment 22173 [details] Changes in all other modules, especially in their project.xml files
Why the hack to apisupport/ant's cp.extra? It should be using the proper dep (o.n.c.modules or whatever core.jar is now) and not this hack. Ditto for autoupdate. And why did you remove apisupport/ant's dep on the ant module? That's wrong, it needs the ant module to be enabled. Could you review the diffs to check for cases like these? Don't make changes to modules in apisupport/project/test/unit/data/example-external-projects/; I think your script is broken on those. Why the funny indentation in websvc/registry/nbproject/project.xml?
The whole source base has been branched and synchronized with BLD200505191800 Use cvs co -r move_58258 standard to get the changes. Btw. currently the commit validation is failing as Jemmy is broken (in trunk) and reads wrong Bundle.properties. Re. Jesse's comment, I'll re-run the ant fix-dependencies once more and will try to follow your suggestions. Then I'll commit the changes to the branch.
Made up-to-date with BLD200505221800. Commit validation will run soon.
Made up-to-date with BLD200505301800
Made up-to-date with BLD200506021800
Created attachment 22495 [details] Log of the merge into main trunk
We agreed with Radim, that I can integrate it, but I will get TCR to improve the startup time.
As log indicates, this is in the trunk now.