This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68912 - [multiview]Clicking comp. error in output doesn't open editor
Summary: [multiview]Clicking comp. error in output doesn't open editor
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Milos Kleint
URL:
Keywords:
: 71219 77158 110575 112230 (view as bug list)
Depends on:
Blocks: 92849
  Show dependency tree
 
Reported: 2005-11-17 20:41 UTC by Milan Kubec
Modified: 2008-12-22 10:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
suggested patch (4.33 KB, patch)
2007-09-11 09:09 UTC, Milos Kleint
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kubec 2005-11-17 20:41:01 UTC
[dev-200511151900, JDK 1.5.0_05]

Steps to reproduce:
1) Create form file, add some component to it
2) Select the component, select 'Code' page of the form properties
3) Open pre-init code editor, type non compilable nonsense, close the editor
4) Compile the form while being in Design mode
Clicking the compilation error doesn't open editor with highlighted error, F12
doesn't work either. Happens only when not swithing to Code editor never before
doing the compilation. Not sure if it's output bug or ant bug or multiview bug,
please reassign.
Comment 1 Milos Kleint 2005-11-18 08:11:21 UTC
a multiview issue
Comment 2 Milos Kleint 2006-01-10 08:39:17 UTC
*** Issue 71219 has been marked as a duplicate of this issue. ***
Comment 3 David Kaspar 2007-08-21 09:39:27 UTC
The same issue is with Visual Designer in Mobility Pack. For now it is workarounded by switching to Source tab manually
within "CloneableEditorSupport.getLineSet" method.
Comment 4 David Kaspar 2007-08-21 14:44:21 UTC
It could be implemented using a marker interface that would have to be implemented by MultiViewDescriptor classes in
case that they are holding editors required to be created/opened before hyperlinking then from an output window.
Comment 5 Milos Kleint 2007-09-11 07:11:50 UTC
*** Issue 77158 has been marked as a duplicate of this issue. ***
Comment 6 Milos Kleint 2007-09-11 07:12:23 UTC
*** Issue 112230 has been marked as a duplicate of this issue. ***
Comment 7 Milos Kleint 2007-09-11 07:55:00 UTC
*** Issue 110575 has been marked as a duplicate of this issue. ***
Comment 8 Milos Kleint 2007-09-11 09:09:26 UTC
Created attachment 48548 [details]
suggested patch
Comment 9 Milos Kleint 2007-09-11 09:18:21 UTC
implemented api enhancement as discussed with dkaspar.

please review.

Comment 10 Jaroslav Tulach 2007-09-11 10:27:53 UTC
Y01 Write test.
Comment 11 Milos Kleint 2007-09-14 06:57:56 UTC
jtulach: the test setup is too complex to be practical to write such test. One needs to create a dataobject/loader and a
multiview with EditorSupport wiring.

Thanks for review, I will integrate shortly.
Comment 12 Milos Kleint 2007-09-14 08:44:03 UTC
integrated, test added.

cvs server: scheduling file `SourceViewMarker.java' for addition
cvs server: use 'cvs commit' to add this file permanently
Checking in src/org/netbeans/core/multiview/MultiViewCloneableTopComponent.java;
/cvs/core/multiview/src/org/netbeans/core/multiview/MultiViewCloneableTopComponent.java,v  <-- 
MultiViewCloneableTopComponent.java
new revision: 1.18; previous revision: 1.17
done
Checking in manifest.mf;
/cvs/core/multiview/manifest.mf,v  <--  manifest.mf
new revision: 1.13; previous revision: 1.12
done
RCS file: /cvs/core/multiview/src/org/netbeans/core/spi/multiview/SourceViewMarker.java,v
done
Checking in src/org/netbeans/core/spi/multiview/SourceViewMarker.java;
/cvs/core/multiview/src/org/netbeans/core/spi/multiview/SourceViewMarker.java,v  <--  SourceViewMarker.java
initial revision: 1.1
done
Checking in test/unit/src/org/netbeans/core/multiview/MultiViewCloneableTopComponentTest.java;
/cvs/core/multiview/test/unit/src/org/netbeans/core/multiview/MultiViewCloneableTopComponentTest.java,v  <-- 
MultiViewCloneableTopComponentTest.java
new revision: 1.5; previous revision: 1.4
done
Checking in api/doc/changes/apichanges.xml;
/cvs/core/multiview/api/doc/changes/apichanges.xml,v  <--  apichanges.xml
new revision: 1.6; previous revision: 1.5
done
Comment 13 Milos Kleint 2007-09-14 08:54:55 UTC
updated form editor

Checking in src/org/netbeans/modules/form/FormEditorSupport.java;
/cvs/form/src/org/netbeans/modules/form/FormEditorSupport.java,v  <--  FormEditorSupport.java
new revision: 1.213; previous revision: 1.212
done
Checking in nbproject/project.xml;
/cvs/form/nbproject/project.xml,v  <--  project.xml
new r