This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Windows Vista LnF NetBeans IDE Dev (Build 200608291800) 1.6.0-rc; Java HotSpot(TM) Client VM 1.6.0-rc-b97 Windows Vista version 6.0 running on x86 cs_CZ (nb); Cp1250 Icons in java project are not taken from LnF. cf. screenshot.
Created attachment 33478 [details] screenshot
Checking in org/netbeans/modules/java/j2seproject/ui/LibrariesNode.java; /cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/LibrariesNode.java,v <-- LibrariesNode.java new revision: 1.24; previous revision: 1.23 done Checking in org/netbeans/spi/java/project/support/ui/PackageRootNode.java; /cvs/java/project/src/org/netbeans/spi/java/project/support/ui/PackageRootNode.java,v <-- PackageRootNode.java new revision: 1.28; previous revision: 1.27 done
TreeRootNode.java missed for fix I have create patch and I have signed Contributor Agreement. Please integrate the patch.
Created attachment 52218 [details] PATCH
I've forgot about the TreeRootNode, I will fix it.
Checking in org/netbeans/spi/java/project/support/ui/TreeRootNode.java; /cvs/java/project/src/org/netbeans/spi/java/project/support/ui/TreeRootNode.java,v <-- TreeRootNode.java new revision: 1.9; previous revision: 1.8 done
The changes in PackageRootNode and TreeRootNode caused issue #121010 (the error and VCS badges do not appear correctly for the "root" nodes).
Sorry for the duplicated comment. I wanted to submit this: BTW: I though that the RTN and PTN inherit the icon from the DataFolder's node (issue #120799), so if the icon from the DF's node would be correct, no changes in java/project should be necessary. Am I mistaken?
When it provides good icon yes, but look on the attached screen shot on windows vista.
From the last Honza comments, it seems that the badging depends on the fact that the node returns icon of underlying node. Right?
Well, the FolderNode (DF's node) does the badging, so reusing its icon provides the badging for free. However, it should (I think) be possible to do the badging separately, by calling: DataObject obj = getDataObject(); img = obj.getPrimaryFile().getFileSystem().getStatus().annotateIcon(img, type, obj.files()); (where img is the propose icon, copied from DF.FN.getIcon). Normally, one would need to do some listening and call fireIconChanged() when necessary, so the icons are updated correctly, but in this case this may be provided by the underlying nodes - needs to be tested.
Where are all the looks and other tries to make at least the view part extensible? The simplest fix is "posleme ho na plicni". I will keep only the fix in Libraries node, revert changes to package root node & tree node node, reopen the issue and assign it to core to provide good icon for DataFolder.
I've fixed the LibrariesNode (j2seproject). The PackageView needs to return the icon of underlaying data folder (the only tested way how to preserve filesystem badges) => DataFolder should provide correct icon on Vista.
Seems to be already fixed in current build.