This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 84503 - Wrong font used in UI on Vista + JDK 1.5
Summary: Wrong font used in UI on Vista + JDK 1.5
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 5.x
Hardware: All Windows Vista
: P2 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: L&F, SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2006-09-08 09:25 UTC by _ tboudreau
Modified: 2008-12-23 00:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
notepad on windows vista (17.75 KB, image/png)
2006-09-18 14:54 UTC, Stanislav Aubrecht
Details
swingset on windows vista, jdk1.5_09ea (22.44 KB, image/png)
2006-09-18 14:54 UTC, Stanislav Aubrecht
Details
netbeans on windows vista, jdk1.5_09ea, antialiasing on (39.38 KB, image/png)
2006-09-18 14:55 UTC, Stanislav Aubrecht
Details
patch for release55 (1.97 KB, patch)
2006-09-18 15:12 UTC, Stanislav Aubrecht
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2006-09-08 09:25:34 UTC
UI controls in NetBeans use a different font than the default one on Windows Vista.

We should take the preemptive step of setting the font correctly ourselves on
Vista.  NetBeans *caused* a lot of the complaints about Swing looking unnatural
back in the pre 3.6 days.  Those complaints are pretty quiet today.

We shouldn't give any reason for that to start up again.
Comment 1 Stanislav Aubrecht 2006-09-13 16:34:37 UTC
i don't think this is a show stopper for release55
Comment 2 _ tboudreau 2006-09-15 00:45:37 UTC
I'd beg to disagree:  NetBeans 5.5 is the first NB release likely to be heavily
used on Vista.  We don't want all of those nasty "Swing sucks, they can't even
do native UI fidelity - all the apps look weird and alien - just look at
NetBeans!" stuff to come back.  It will come back.

We're talking about a trivial amount of code here - come on, we can do this.
Comment 3 Marian Mirilovic 2006-09-15 08:15:39 UTC
I tend to agree with Tim. 
I know we are in HR but if the fix is really simple, I vote for integration.
Comment 4 Stanislav Aubrecht 2006-09-15 11:06:29 UTC
ok, i'll look at it with dafe when he's back from vacations.
but netbeans will *never* look good on windows vista & jdk1.5 - the editor and
view tabs are using xp look and feel in this case. so wrong fonts in the menu
are just a minor issue i think:)
Comment 5 _ tboudreau 2006-09-15 23:33:28 UTC
If you can detect vista to set the font correctly on 1.5, shouldn't you be able
to use the same logic to detect vista to set the tab UI delegates?
Comment 6 Stanislav Aubrecht 2006-09-18 14:54:15 UTC
Created attachment 34083 [details]
notepad on windows vista
Comment 7 Stanislav Aubrecht 2006-09-18 14:54:54 UTC
Created attachment 34084 [details]
swingset on windows vista, jdk1.5_09ea
Comment 8 Stanislav Aubrecht 2006-09-18 14:55:46 UTC
Created attachment 34085 [details]
netbeans on windows vista, jdk1.5_09ea, antialiasing on
Comment 9 Stanislav Aubrecht 2006-09-18 15:04:41 UTC
use vista ui for tabs & output also when running on jdk1.5

Checking in swing/plaf/src/org/netbeans/swing/plaf/Startup.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/Startup.java,v  <--  
Startup.java
new revision: 1.19; previous revision: 1.18
done
Checking in 
output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java;
/cvs/core/output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java,v
  <--  CloseButtonTabbedPane.java
new revision: 1.14; previous revision: 1.13
done
Comment 10 Stanislav Aubrecht 2006-09-18 15:12:09 UTC
Created attachment 34088 [details]
patch for release55
Comment 11 Stanislav Aubrecht 2006-09-18 15:16:12 UTC
i think the font in netbeans' menu bar is more or less correct. see the 
attached screenshots to compare vista notepad, swingset demo and netbeans ide 
running with aa turned on.
tuning the font might be a bit dangerous as there's only windows vista *beta* 
and jdk1.5_09 doesn't fully recognize the vista anyway. if i fix the font now 
then the ide may look even worse when the final vista is released.

i'll just fix the ui to use vista style also when running on jdk1.5 which is a 
simple fix (see the attached patch) and improves the look and feel a lot.
Comment 12 Stanislav Aubrecht 2006-09-20 11:26:44 UTC
fixed in release55_dev branch

Checking in output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java;
/cvs/core/output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java,v
 <--  CloseButtonTabbedPane.java
new revision: 1.8.68.2.14.2; previous revision: 1.8.68.2.14.1
done
Checking in swing/plaf/src/org/netbeans/swing/plaf/Startup.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/Startup.java,v  <--  Startup.java
new revision: 1.14.12.1.2.1.14.2; previous revision: 1.14.12.1.2.1.14.1
done
Comment 13 David Simonek 2006-09-22 11:08:06 UTC
patch reviewed, OK.
Comment 14 Stanislav Aubrecht 2006-09-22 12:53:29 UTC
fixed in release55 branch

Checking in swing/plaf/src/org/netbeans/swing/plaf/Startup.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/Startup.java,v  <--  Startup.java
new revision: 1.14.12.1.2.3; previous revision: 1.14.12.1.2.2
done
Checking in output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java;
/cvs/core/output2/src/org/netbeans/core/output2/ui/CloseButtonTabbedPane.java,v
 <--  CloseButtonTabbedPane.java
new revision: 1.8.68.4; previous revision: 1.8.68.3
done
Comment 15 Marian Mirilovic 2006-09-26 14:32:47 UTC
verified