This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 93307 - small UI damage of java project configuration combobox in toolbar
Summary: small UI damage of java project configuration combobox in toolbar
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Project (show other bugs)
Version: 6.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: David Simonek
URL:
Keywords: L&F, REGRESSION, UI
Depends on:
Blocks:
 
Reported: 2007-01-26 13:00 UTC by Tomas Danek
Modified: 2007-09-14 15:46 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot of combobox (1.23 KB, image/png)
2007-01-26 13:01 UTC, Tomas Danek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2007-01-26 13:00:31 UTC
NetBeans IDE Dev (Build 200701251900)
1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105
Linux version 2.6.17-10-generic running on i386
cs_CZ (nb); UTF-8

-----------------------
- start ide,have no project is opened. 
- project configuration combobox in toolbar is present - AFAIK it used to be
diplayed only if java project was opened? I missed something?
- open or create j2se project, item in combo looks ugly on my machine (kubuntu),
see screenshot
Comment 1 Tomas Danek 2007-01-26 13:01:20 UTC
Created attachment 37718 [details]
screenshot of combobox
Comment 2 Jesse Glick 2007-01-27 00:56:36 UTC
I think due to Dafe's recent GTK changes? Perhaps make them conditional on GTK
L&F, or if not then at least test on other L&Fs.
Comment 3 David Simonek 2007-01-31 11:45:17 UTC
Fixed to work OK on all LFs.

I made combo visible (but disabled) if no project is opened intentionally - I
think it's more aligned with behaviour of other toolbar items, they don't vanish
as well. (and moreover hiding didn't work on GTK, free space appeared here).
Comment 4 Jesse Glick 2007-02-02 23:12:41 UTC
(Please include commit log messages in IZ. Looks like you did 1.6 and 1.7 of
projects/projectui/src/org/netbeans/modules/project/ui/actions/ActiveConfigAction.java.)

It was agreed before that we prefer for the combo to be hidden, not just
disabled, when it is inapplicable. That is what saubrecht's 1.5 commit
accomplished. (I was unable to get it to work when I wrote the class but he
figured it out.) Jano, what do you think?
Comment 5 jrojcek 2007-02-05 08:48:04 UTC
Yes, when we implemented the configuration combo box I agreed to hide the combo if the main project 
doesn't support configurations.

I still think it's better to hide the combo box, mostly because the configurations are not supported by 
Enterprise and Web projects. This means there's a group of users (ent/web app developers) who would 
have a completely useless disabled combo box  in the main toolbar all the time. In addition, the 
configurations don't work with freeform projects.

I think in general, controls should not appear/disappear, but this is more like showing/hiding debugger 
toolbar or palette window when it's needed. 

Ideally the configurations would be supported by ent/web app projects as well. AFAIK, there's a few use 
cases when it might be handy.
Comment 6 David Simonek 2007-02-05 09:52:59 UTC
The problem is I'm not able to implement hiding combo box on GTK well. There is
always a space left, it seems GTK toolbars have problems with hidden items...
Comment 7 Tomas Danek 2007-09-14 15:46:23 UTC
combobox looks fine now on my system. Verified 20070914.