This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Combo boxes with custom renderers doesn't have correct border and size on GTK LF, which looks bad. Reason is JDK bug #6505565. However even after the fix of JDK bug, some adjusting of combo box renderers is needed. This is umbrella bug to fix combo boxes look across the IDE for JDK 1.6.0 update 1 and higher.
fix in refactoring module: Checking in CopyClassPanel.java; /cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassPanel.java,v <-- CopyClassPanel.java new revision: 1.6; previous revision: 1.5 done Checking in MoveClassPanel.java; /cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassPanel.java,v <-- MoveClassPanel.java new revision: 1.3; previous revision: 1.2
fixed html renderer: Checking in HtmlRendererImpl.java; /cvs/openide/awt/src/org/openide/awt/HtmlRendererImpl.java,v <-- HtmlRendererImpl.java new revision: 1.5; previous revision: 1.4 done Checking in HtmlLabelUI.java; /cvs/openide/awt/src/org/openide/awt/HtmlLabelUI.java,v <-- HtmlLabelUI.java new revision: 1.14; previous revision: 1.13 done
fixing in other modules: Checking in NewCommandVisualPanel.java; /cvs/ant/freeform/samples/src/org/netbeans/modules/ant/freeform/customcommands/NewCommandVisualPanel.java,v <-- NewCommandVisualPanel.java new revision: 1.3; previous revision: 1.2 Checking in JUnitCfgOfCreate.java; /cvs/junit/src/org/netbeans/modules/junit/JUnitCfgOfCreate.java,v <-- JUnitCfgOfCreate.java new revision: 1.41; previous revision: 1.40 Checking in LocalePanel.form; /cvs/properties/src/org/netbeans/modules/properties/LocalePanel.form,v <-- LocalePanel.form new revision: 1.8; previous revision: 1.7 done Checking in LocalePanel.java; /cvs/properties/src/org/netbeans/modules/properties/LocalePanel.java,v <-- LocalePanel.java new revision: 1.17; previous revision: 1.16 done
fixed combo boxes in J2SE projects and project support, api support: Checking in java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java; /cvs/java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java,v <-- PackageView.java new revision: 1.18; previous revision: 1.17 done Checking in java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerRun.java; /cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerRun.java,v <-- CustomizerRun.java new revision: 1.24; previous revision: 1.23 done Checking in apisupport/project/src/org/netbeans/modules/apisupport/project/ui/UIUtil.java; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/UIUtil.java,v <-- UIUtil.java new revision: 1.35; previous revision: 1.34 done Checking in apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/JavaPlatformComponentFactory.java; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/JavaPlatformComponentFactory.java,v <-- JavaPlatformComponentFactory.java new revision: 1.5; previous revision: 1.4 done Checking in apisupport/project/src/org/netbeans/modules/apisupport/project/ui/wizard/action/GUIRegistrationPanel.java; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/wizard/action/GUIRegistrationPanel.java,v <-- GUIRegistrationPanel.java new revision: 1.32; previous revision: 1.31 done Checking in apisupport/project/src/org/netbeans/modules/apisupport/project/ui/platform/LibrariesModel.java; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/platform/LibrariesModel.java,v <-- LibrariesModel.java new revision: 1.6; previous revision: 1.5 done Checking in apisupport/project/src/org/netbeans/modules/apisupport/project/ui/platform/PlatformComponentFactory.java; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/platform/PlatformComponentFactory.java,v <-- PlatformComponentFactory.java new revision: 1.13; previous revision: 1.12 done
Fixed all occurences of the bug I knew.
One more fix for encoding combo box in j2se project customizer: Checking in CustomizerSources.java; /cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerSources.java,v <-- CustomizerSources.java new revision: 1.16; previous revision: 1.15 done
Another two fixes in java/freeform project. Encoding and Java Platform combo boxes. Checking in SourceFoldersPanel.java; /cvs/java/freeform/src/org/netbeans/modules/java/freeform/ui/SourceFoldersPanel.java,v <-- SourceFoldersPanel.java new revision: 1.25; previous revision: 1.24 done Checking in ClasspathPanel.java; /cvs/java/freeform/src/org/netbeans/modules/java/freeform/ui/ClasspathPanel.java,v <-- ClasspathPanel.java new revision: 1.13; previous revision: 1.12 done
Rather than creating copy-pasted code like this everywhere, wouldn't it make sense to have a simple utility class in o.o.awt which would essentially be a replacement for DefaultListCellRenderer? E.g. public abstract class NbListCellRendererFactory<T> { protected NbListCellRenderer() {} protected abstract String labelFor(T object); public final ListCellRenderer createRenderer(); }
I created similar solution but you Jesse refused it as I remember - you said that we shouldn't create API to just workaround JDK issue...