95977 – [Refactoring-review-TCR] Use Lookup instead of Object where appropriate

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 95977 - [Refactoring-review-TCR] Use Lookup instead of Object where appropriate

Summary: [Refactoring-review-TCR] Use Lookup instead of Object where appropriate

Status:	RESOLVED FIXED

Alias:	None

Product:	editor
Classification:	Unclassified
Component:	Refactoring (show other bugs)
Version:	6.x
Hardware:	PC Linux

Importance:	P2 blocker (vote)
Assignee:	issues@java

URL:
Keywords:

Depends on:
Blocks:	89605
	Show dependency tree

Reported:	2007-02-19 23:28 UTC by Miloslav Metelka
Modified:	2007-04-03 18:02 UTC (History)
CC List:	0 users

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Miloslav Metelka 2007-02-19 23:28:06 UTC

As discussed on the review rather than going through the objects and asking them
by "instanceof" the Lookup is more suitable in returning collections of objects
of certain type.

Review wiki page: http://wiki.netbeans.org/wiki/view/RefactoringAPIReview

Comment 1 Jan Becicka 2007-02-20 12:17:11 UTC

Lookup used everywhere.

now use 
refactoring.getRefactoringSource().lookup(someclass) or lookupAll(someclass)
instead of getRefactoredObjects() plus casting
and use for instance
URL target = refactoring.getTarget().lookup(URL.class);
URL target = (URL) refactoring.getTarget();

Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/CopyClassRefactoringPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/CopyClassRefactoringPlugin.java,v
 <--  CopyClassRefactoringPlugin.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/MoveRefactoringPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/MoveRefactoringPlugin.java,v
 <--  MoveRefactoringPlugin.java
new revision: 1.11; previous revision: 1.10
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/JavaRefactoringsFactory.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/JavaRefactoringsFactory.java,v
 <--  JavaRefactoringsFactory.java
new revision: 1.9; previous revision: 1.8
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/RenameRefactoringPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/RenameRefactoringPlugin.java,v
 <--  RenameRefactoringPlugin.java
new revision: 1.14; previous revision: 1.13
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/SafeDeleteRefactoringPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/SafeDeleteRefactoringPlugin.java,v
 <--  SafeDeleteRefactoringPlugin.java
new revision: 1.9; previous revision: 1.8
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/PackageRename.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/PackageRename.java,v
 <--  PackageRename.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/JavaWhereUsedQueryPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/JavaWhereUsedQueryPlugin.java,v
 <--  JavaWhereUsedQueryPlugin.java
new revision: 1.14; previous revision: 1.13
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/RefactoringElementsBag.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/RefactoringElementsBag.java,v
 <--  RefactoringElementsBag.java
new revision: 1.13; previous revision: 1.12
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassUI.java,v
 <--  MoveClassUI.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassRefactoringUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassRefactoringUI.java,v
 <--  CopyClassRefactoringUI.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RefactoringActionsProvider.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RefactoringActionsProvider.java,v
 <--  RefactoringActionsProvider.java
new revision: 1.19; previous revision: 1.18
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/JavaRefactoringActionsProvider.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/JavaRefactoringActionsProvider.java,v
 <--  JavaRefactoringActionsProvider.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/SafeDeletePanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/SafeDeletePanel.java,v
 <--  SafeDeletePanel.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/JavaActionsImplementationFactory.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/JavaActionsImplementationFactory.java,v
 <--  JavaActionsImplementationFactory.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RenamePanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RenamePanel.java,v
 <--  RenamePanel.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/ExtractInterfaceAction.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/ExtractInterfaceAction.java,v
 <--  ExtractInterfaceAction.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/SafeDeleteUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/SafeDeleteUI.java,v
 <--  SafeDeleteUI.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassPanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassPanel.java,v
 <--  MoveClassPanel.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/WhereUsedQueryUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/WhereUsedQueryUI.java,v
 <--  WhereUsedQueryUI.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/ExtractInterfacePanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/ExtractInterfacePanel.java,v
 <--  ExtractInterfacePanel.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RenameRefactoringUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/RenameRefactoringUI.java,v
 <--  RenameRefactoringUI.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/WhereUsedPanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/WhereUsedPanel.java,v
 <--  WhereUsedPanel.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassesUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/MoveClassesUI.java,v
 <--  MoveClassesUI.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassPanel.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassPanel.java,v
 <--  CopyClassPanel.java
new revision: 1.7; previous revision: 1.6
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/ParametersPanel.java,v
 <--  ParametersPanel.java
new revision: 1.10; previous revision: 1.9
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RenameAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RenameAction.java,v
 <--  RenameAction.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/MoveAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/MoveAction.java,v
 <--  MoveAction.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RefactoringGlobalAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RefactoringGlobalAction.java,v
 <--  RefactoringGlobalAction.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeletePanel.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeletePanel.java,v
 <--  SafeDeletePanel.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeleteAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeleteAction.java,v
 <--  SafeDeleteAction.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/CopyAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/CopyAction.java,v
 <--  CopyAction.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeleteUI.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/SafeDeleteUI.java,v
 <--  SafeDeleteUI.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/WhereUsedAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/WhereUsedAction.java,v
 <--  WhereUsedAction.java
new revision: 1.4; previous revision: 1.3
done
Checking in
web/jsf/src/org/netbeans/modules/web/jsf/refactoring/JSFWhereUsedPlugin.java;
/cvs/web/jsf/src/org/netbeans/modules/web/jsf/refactoring/JSFWhereUsedPlugin.java,v
 <--  JSFWhereUsedPlugin.java
new revision: 1.5; previous revision: 1.4
done
Checking in
web/jsf/src/org/netbeans/modules/web/jsf/refactoring/JSFRenamePlugin.java;
/cvs/web/jsf/src/org/netbeans/modules/web/jsf/refactoring/JSFRenamePlugin.java,v
 <--  JSFRenamePlugin.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/ui/CustomRefactoringPanel.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/ui/CustomRefactoringPanel.java,v
 <--  CustomRefactoringPanel.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/spi/ui/ActionsImplementationProvider.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/ui/ActionsImplementationProvider.java,v
 <--  ActionsImplementationProvider.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/MultipleCopyRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/MultipleCopyRefactoring.java,v
 <--  MultipleCopyRefactoring.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/RenameRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/RenameRefactoring.java,v
 <--  RenameRefactoring.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/WhereUsedQuery.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/WhereUsedQuery.java,v
 <--  WhereUsedQuery.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/AbstractRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/AbstractRefactoring.java,v
 <--  AbstractRefactoring.java
new revision: 1.6; previous revision: 1.5
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/SafeDeleteRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/SafeDeleteRefactoring.java,v
 <--  SafeDeleteRefactoring.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/SingleCopyRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/SingleCopyRefactoring.java,v
 <--  SingleCopyRefactoring.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/RefactoringElement.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/RefactoringElement.java,v
 <--  RefactoringElement.java
new revision: 1.7; previous revision: 1.6
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/MoveRefactoring.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/MoveRefactoring.java,v
 <--  MoveRefactoring.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileCopyPlugin.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileCopyPlugin.java,v
 <--  FileCopyPlugin.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/DefaultActionsProvider.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/DefaultActionsProvider.java,v
 <--  DefaultActionsProvider.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileHandlingFactory.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileHandlingFactory.java,v
 <--  FileHandlingFactory.java
new revision: 1.5; previous revision: 1.4
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileRenamePlugin.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileRenamePlugin.java,v
 <--  FileRenamePlugin.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileDeletePlugin.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileDeletePlugin.java,v
 <--  FileDeletePlugin.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java,v
 <--  FileMovePlugin.java
new revision: 1.7; previous revision: 1.6
done
Checking in
refactoring/api/test/unit/src/org/netbeans/modules/refactoring/java/RefactoringTest.java;
/cvs/refactoring/api/test/unit/src/org/netbeans/modules/refactoring/java/RefactoringTest.java,v
 <--  RefactoringTest.java
new revision: 1.4; previous revision: 1.3
done
Checking in
refactoring/api/test/unit/src/org/netbeans/modules/refactoring/api/ui/ActionInvocationTest.java;
/cvs/refactoring/api/test/unit/src/org/netbeans/modules/refactoring/api/ui/ActionInvocationTest.java,v
 <--  ActionInvocationTest.java
new revision: 1.3; previous revision: 1.2
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/spi/ui/JavaActionsImplementationProvider.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/spi/ui/JavaActionsImplementationProvider.java,v
 <--  JavaActionsImplementationProvider.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/java/src/org/netbeans/modules/refactoring/java/api/ExtractInterfaceRefactoring.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/api/ExtractInterfaceRefactoring.java,v
 <--  ExtractInterfaceRefactoring.java
new revision: 1.2; previous revision: 1.1
done
Checking in
refactoring/api/src/org/netbeans/modules/refactoring/api/impl/ActionsImplementationFactory.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/impl/ActionsImplementationFactory.java,v
 <--  ActionsImplementationFactory.java
new revision: 1.3; previous revision: 1.2
done
Checking in
java/src/org/netbeans/modules/refactoring/java/plugins/CopyClassRefactoringPlugin.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/CopyClassRefactoringPlugin.java,v
 <--  CopyClassRefactoringPlugin.java
new revision: 1.7; previous revision: 1.6
done
Checking in api/src/org/netbeans/modules/refactoring/plugins/FileCopyPlugin.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/plugins/FileCopyPlugin.java,v
 <--  FileCopyPlugin.java
new revision: 1.6; previous revision: 1.5
done
Checking in
java/src/org/netbeans/modules/refactoring/java/ui/CopyClassRefactoringUI.java;
/cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/ui/CopyClassRefactoringUI.java,v
 <--  CopyClassRefactoringUI.java
new revision: 1.7; previous revision: 1.6
done