This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 97968 - The list of tags in Search History window is broken
Summary: The list of tags in Search History window is broken
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 6.x
Hardware: PC Windows XP
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords: DUAL_MONITOR
Depends on:
Blocks:
 
Reported: 2007-03-15 14:01 UTC by kirillkh
Modified: 2007-08-08 08:25 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kirillkh 2007-03-15 14:01:54 UTC
When "Tags" column in the Search History window has more than 1 tags for certain
revision, only the first one is shown, and "..." link appears. I figure this
link should open a list of all tags defined on the selected revision. But this
is not the case: clicking the link doesn't do anything special.
Comment 1 Maros Sandor 2007-03-19 10:40:10 UTC
So. you click on the link and it does nothing? Does it happen for all tags for
all files or is it specific to some files/servers?
Comment 2 kirillkh 2007-03-19 11:14:46 UTC
Haven't tried it with anything but our local CVS server (some standard version
on Linux). It happens with all files and tags.
Comment 3 Maros Sandor 2007-03-19 17:09:45 UTC
Pick up one file, and do Search History on the file. Please attach here what you
see in the Diff view, especially the Tags column and also please attach the
output of 'cvs log' on that file so that we can compare those outputs. Also
please try some other CVS server (netbeans' for example) and see if you can
reproduce the bug there also.
Comment 4 kirillkh 2007-03-20 13:10:07 UTC
Figured it out: appears to be a dual-monitor issue. I'm usually opening the main
NB window on the second monitor, and that's where the tags list doesn't show up.
After moving the window to the primary monitor the list shows all right.
Comment 5 Maros Sandor 2007-03-21 11:12:42 UTC
Not a bug in CVS module.
Comment 6 kirillkh 2007-03-21 11:15:08 UTC
Sure, but it's a bug nevertheless, isn't it? I was hoping you would transfer it
to the appropriate module. I have no problem filing a new one, though, if that's
what it takes.
Comment 7 Maros Sandor 2007-03-21 11:35:54 UTC
Please do so if you wish though I doubt this is a bug in NetBeans.
Comment 8 kirillkh 2007-03-21 11:48:07 UTC
I'm pretty sure it is, actually.. I've run into similar dual-monitor bugs in the
past. See, I don't have problems with any other pop-up menus in NB. So this
pop-up menu must be special. Since I have no idea, how it is special, I'll still
need your advice to decide, against which module to file it. My current guess
is, though, that it can well be a problem with CVS module's GUI - not using the
right API for showing/positioning the menu or something of that kind.
Comment 9 kirillkh 2007-03-23 14:09:14 UTC
OK, so what I'm doing is reopening the issue, since I believe it to be valid and
still suspect cvs/code might be the culprit. If it's found to be elsewhere,
please reassign.
Comment 10 Maros Sandor 2007-03-23 16:01:19 UTC
I have tested it on dual-monitor Windows and dual-monitor Linux system and have
not encountered any issues. The same window is used in Diff sidebar. Try to
click on a blue or red difference in the Editor's Diff sidebar and a window will
pop up showing the original text. Is this positioned correctly?
Comment 11 kirillkh 2007-03-23 21:00:14 UTC
I won't be able to test this until the end of the month.
Comment 12 kirillkh 2007-03-23 21:06:30 UTC
But I can suggest doing an additional test with primary monitor configured at
1024x768 resolution and the secondary monitor at 1280x1024.
Comment 13 kirillkh 2007-04-01 11:58:56 UTC
> Try to click on a blue or red difference in the Editor's Diff sidebar and a
window will pop up showing the original text. Is this positioned correctly?

Thanks for the tip, I didn't know it was supposed to show the original text.
Well, same story: the original source pop-up only appears on the primary monitor
and doesn't appear on the secondary. Interestingly, the four-button pop-up ("Go
to previous difference", "Replace with original text", etc.) doesn't have this
problem (i.e. correctly appears on both monitors). HTH.
Comment 14 kirillkh 2007-05-03 11:59:13 UTC
dear cvs,

i need diff and tags list windows displayed on dual-screen

thanks
-kk

(C)issue #97732
Comment 15 Maros Sandor 2007-05-03 12:09:59 UTC
All dual screen machines we have checked here work just fine (running Ubuntu
KDE, Fedora and Windows XP) so we cannot really track the problem down now.
Comment 16 kirillkh 2007-05-03 12:26:38 UTC
Hvae you checked laptop + desktop monitor configuration? Mine is Dell Latitude
D505 with laptop configured as the primary monitor.
Comment 17 Maros Sandor 2007-05-03 12:30:08 UTC
Yes, we have also checked a laptop with an external monitor and also tried to
swap primary and secondary displays.
Comment 18 kirillkh 2007-05-03 12:31:48 UTC
I'm going to raise this issue on nbusers and see, if anyone can reproduce it.
Comment 19 vaughn 2007-05-04 06:48:35 UTC
Responding to nbusers post at http://www.nabble.com/Dual-monitor-issue-and-NB-
6.0-tf3685940.html, asking for help reproducing this issue. I did see a 
problem, but not as described by kirillkh. I have a dual monitor desktop 
running Windows XP Pro. Here's how I reproduced the problem. 

In the Favorites window right click any file that's under cvs source control. 
Choose: cvs > search history. In the Search History window select the Diff 
tab. Open the history tree to expose version history messages. Click any 
message, and a Commit Message window will pop up. The Commit Message always 
pops up in the same monitor, regardless of the monitor that displays the IDE. 
The problem reminded me of the old bug that caused menus to appear in the 
wrong monitor, but that bug has been fixed.

This is the only problem I saw. All other pop up windows and menus appeared 
where they should, in the monitor that displays the IDE.
Comment 20 Peter Pis 2007-05-04 07:42:57 UTC
vaughn: I have reproduce that. (Dual monitor: laptop's screen uses primary,
secondary is used by LCD). Only "Commit message" popup of Search History seems
to be shown on inappropriate location. Thanks.
Comment 21 kirillkh 2007-05-04 10:49:11 UTC
I have been thinking of a possible solution to the problem for some time. As I
said, when I click on the diff stripe, I always get the four-buttons panel
displayed properly. Maybe all that's required for fixing this bug is making all
other windows behave exactly like that one?
Comment 22 Maros Sandor 2007-06-01 13:59:50 UTC
I can reproduce it now if I run the IDE on secondary display.
Comment 23 kirillkh 2007-06-01 14:05:30 UTC
Whoa! Did you do anything special for that?
Comment 24 Maros Sandor 2007-06-01 14:12:41 UTC
Actually yes, I had to bring my notebook to the office.
Comment 25 kirillkh 2007-06-17 15:56:17 UTC
I have just noticed that in 070612 build the situation has improved:

1. tags list seems to work correctly
2. in-editor diff (the one you get, when clicking a blue stripe on the left) seems to work correctly
3. commit comments in the History Diff view show up on the primary screen - the single problem still left

Is it a result of changes you made or is it my configuration? The only thing I recently changed in this respect is
moving the secondary (desktop) monitor to the left, whilst formerly it was configured to extend the desktop to the right.

BTW, while it's not too late in the release cycle... Please consider making all these pop-ups appear on mouseover, as
opposed to mouseclick. The way it works now in Search History requires clicking a column in the line with the
interesting revision. The problem is this has additional effect of changing the selected revision and re-displaying the
diff content for it. Additionally, in my opinion mouseover behavior doesn't have any disadvantages over mouseclick, but
is more discoverable and requires less effort (right now it's not only the click to show the pop-up, but also another
click to hide it, and you have to know, where to click).
Comment 26 kirillkh 2007-06-17 16:09:26 UTC
Submitted a separate issue for the "mouseover" rant: issue #106936
Comment 27 Maros Sandor 2007-08-08 08:25:25 UTC
I did not change anything prior to this fix ... all should be OK now, please verify in latest builds.

/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/history/TooltipWindow.java,v
 <--  TooltipWindow.java
new revision: 1.2; previous revision: 1.1
/shared/data/ccvs/repository/versioncontrol/src/org/netbeans/modules/versioning/diff/DiffActionTooltipWindow.java,v  <--
 DiffActionTooltipWindow.java
new revision: 1.5; previous revision: 1.4