This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 98089 - Make deploy and startup timeout settable
Summary: Make deploy and startup timeout settable
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vince Kraemer
URL:
Keywords:
Depends on:
Blocks: 96822
  Show dependency tree
 
Reported: 2007-03-16 14:38 UTC by Vince Kraemer
Modified: 2007-04-10 23:07 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
api change info (3.54 KB, text/plain)
2007-03-16 18:23 UTC, Vince Kraemer 		Details
revised patch (3.63 KB, text/plain)
2007-03-22 19:28 UTC, Vince Kraemer 		Details
one more time... (3.76 KB, text/plain)
2007-03-23 04:45 UTC, Vince Kraemer 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vince Kraemer 2007-03-16 14:38:56 UTC 
When the j2eeserver layer calls a plugin's StartServer.startTarget() method or
triggers a deploy operation, the code waits to see if the actions completes. 
The timeout is currently hard-coded and large (~20 minutes).

I propose that InstanceProperties be extended with two new constants, 
STARTUP_TIMEOUT and DEPLOYMENT_TIMEOUT.  If a plugin defines an instance
property with these names, their value is interpreted as the  number of seconds
to use as the timeout.  If the property isn't defined, the old default would
continue to be used.

This allows the plugin to change the timeout on a per-instance basis.  This may
be useful in situations where deployment is being done over a congested link.
Comment 1 Sherold Dev 2007-03-16 14:46:07 UTC 
Would it be useful to introduce also the SHUTDOWN_TIMEOUT constant?
Comment 2 Vince Kraemer 2007-03-16 17:19:37 UTC 
That sounds reasonable and easy.
Comment 3 Vince Kraemer 2007-03-16 18:23:40 UTC 
Created attachment 39599 [details]
api change info
Comment 4 Sherold Dev 2007-03-22 14:34:32 UTC 
Vince, could you please add that SHUTDOWN_TIMEOUT constant there, or should I
modify your diff?
Comment 5 Vince Kraemer 2007-03-22 16:27:45 UTC 
opps.. sure.  I will get that attached today.
Comment 6 Vince Kraemer 2007-03-22 19:28:43 UTC 
Created attachment 39836 [details]
revised patch
Comment 7 Sherold Dev 2007-03-22 22:55:28 UTC 
Thanks

I have just noticed that the @since tag is missing in the method javadocs,
otherwise the patch looks good.
Comment 8 Vince Kraemer 2007-03-23 04:45:59 UTC 
Created attachment 39854 [details]
one more time...
Comment 9 Libor Kotouc 2007-03-28 14:33:49 UTC 
The fix was integrated into trunk.

Checking in apichanges.xml;
/cvs/j2eeserver/apichanges.xml,v  <--  apichanges.xml
new revision: 1.24; previous revision: 1.23
done
Checking in nbproject/project.properties;
/cvs/j2eeserver/nbproject/project.properties,v  <--  project.properties
new revision: 1.15; previous revision: 1.14
done
Checking in
src/org/netbeans/modules/j2ee/deployment/plugins/api/InstanceProperties.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/InstanceProperties.java,v
 <--  InstanceProperties.java
new revision: 1.20; previous revision: 1.19
done
Comment 10 Vince Kraemer 2007-04-10 23:07:29 UTC 
since this is integrated... isn't it closed now? Do I need to do something else
on this?